Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933177AbbFIQBY (ORCPT ); Tue, 9 Jun 2015 12:01:24 -0400 Received: from mga01.intel.com ([192.55.52.88]:50358 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932571AbbFIQBM (ORCPT ); Tue, 9 Jun 2015 12:01:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,581,1427785200"; d="scan'208";a="740176607" Message-ID: <1433863818.26331.97.camel@linux.intel.com> Subject: Re: [PATCH v11 5/5] x86/earlyprintk: Patch for testing earlyprintk From: Andy Shevchenko To: Alexander Kuleshov Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , LKML , Greg Kroah-Hartman , Borislav Petkov , Mark Rustad , Yinghai Lu Date: Tue, 09 Jun 2015 18:30:18 +0300 In-Reply-To: <1433848318-6062-1-git-send-email-kuleshovmail@gmail.com> References: <1433848247-3550-1-git-send-email-kuleshovmail@gmail.com> <1433848318-6062-1-git-send-email-kuleshovmail@gmail.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2307 Lines: 80 On Tue, 2015-06-09 at 17:11 +0600, Alexander Kuleshov wrote: > Signed-off-by: Alexander Kuleshov Please, mark those patches as something like "[NOT TO APPLY]". Or you may (if others have no objections) create a configuration option like CONFIG_TEST_EARLY_PRINTK and make this patch upstreamable. See below. > --- > arch/x86/kernel/head64.c | 1 + > arch/x86/kernel/setup.c | 1 + > init/main.c | 2 +- > 3 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c > index 041be2c..1d1d167 100644 > --- a/arch/x86/kernel/head64.c > +++ b/arch/x86/kernel/head64.c > @@ -204,5 +204,6 @@ void __init x86_64_start_reservations(char *real_mode_data) > > reserve_ebda_region(); > > + early_printk("Go on the start_kernel\n"); #ifdef CONFIG_TEST_EARLY_PRINTK early_printk("%s: Starting kernel...\n", __func__); #endif > start_kernel(); > } > diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c > index edfdb6a..22e8f39 100644 > --- a/arch/x86/kernel/setup.c > +++ b/arch/x86/kernel/setup.c > @@ -876,6 +876,7 @@ void __init setup_builtin_cmdline(void) > > void __init setup_arch(char **cmdline_p) > { > + early_printk("Now setup arch is working\n"); #ifdef CONFIG_TEST_EARLY_PRINTK early_printk("%s: Enter\n", __func__); #endif > memblock_reserve(__pa_symbol(_text), > (unsigned long)__bss_stop - (unsigned long)_text); > > diff --git a/init/main.c b/init/main.c > index 2115055..79087b8 100644 > --- a/init/main.c > +++ b/init/main.c > @@ -493,7 +493,7 @@ asmlinkage __visible void __init start_kernel(void) > { > char *command_line; > char *after_dashes; > - This removal is wrong. Leave empty string after definition block. > + early_printk("start_kernel function started to work\n"); #ifdef CONFIG_TEST_EARLY_PRINTK early_printk("%s: Enter\n", __func__); #endif > /* > * Need to run as early as possible, to initialize the > * lockdep hash: -- Andy Shevchenko Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/