Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933217AbbFIPgG (ORCPT ); Tue, 9 Jun 2015 11:36:06 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:39062 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752106AbbFIPfu (ORCPT ); Tue, 9 Jun 2015 11:35:50 -0400 X-Originating-IP: 83.155.44.161 Message-ID: <1433864144.5707.5.camel@hadess.net> Subject: Re: [PATCH v2 2/8] input: goodix: fix variable length array warning From: Bastien Nocera To: Irina Tirdea Cc: Dmitry Torokhov , Mark Rutland , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala Date: Tue, 09 Jun 2015 17:35:44 +0200 In-Reply-To: <1433774273-23103-3-git-send-email-irina.tirdea@intel.com> References: <1433774273-23103-1-git-send-email-irina.tirdea@intel.com> <1433774273-23103-3-git-send-email-irina.tirdea@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.2.1 (3.16.2.1-1.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1591 Lines: 46 On Mon, 2015-06-08 at 17:37 +0300, Irina Tirdea wrote: > Fix sparse warning: > drivers/input/touchscreen/goodix.c:182:26: warning: > Variable length array is used. > > Replace the variable length array with fixed length. > > Some Goodix devices have maximum 5 touch points, while > others have 10 touch points. Using the maximum length > (80 bytes) for all devices will lead to wasting 40 bytes > when using devices with maximum 5 touch points. However, > that is prefferable to using kmalloc which will use even ^^^^^^^^^^^ preferable > more resources. > > Signed-off-by: Irina Tirdea Acked-by: Bastien Nocera > --- > drivers/input/touchscreen/goodix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/goodix.c > b/drivers/input/touchscreen/goodix.c > index a65e4d9..18557e4 100644 > --- a/drivers/input/touchscreen/goodix.c > +++ b/drivers/input/touchscreen/goodix.c > @@ -147,7 +147,7 @@ static void goodix_ts_report_touch(struct > goodix_ts_data *ts, u8 *coor_data) > */ > static void goodix_process_events(struct goodix_ts_data *ts) > { > - u8 point_data[1 + GOODIX_CONTACT_SIZE * ts->max_touch_num]; > + u8 point_data[1 + GOODIX_CONTACT_SIZE * > GOODIX_MAX_CONTACTS]; > int touch_num; > int i; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/