Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753599AbbFIPt4 (ORCPT ); Tue, 9 Jun 2015 11:49:56 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:50431 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752594AbbFIPtt (ORCPT ); Tue, 9 Jun 2015 11:49:49 -0400 Date: Tue, 9 Jun 2015 16:49:36 +0100 From: Mark Brown To: Richard Fitzgerald Cc: lgirdwood@gmail.com, patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Message-ID: <20150609154936.GC14071@sirena.org.uk> References: <1433774222-25103-1-git-send-email-rf@opensource.wolfsonmicro.com> <20150608174041.GK14071@sirena.org.uk> <20150609120641.GA9887@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wyYQCv9VYpiQX0rh" Content-Disposition: inline In-Reply-To: <20150609120641.GA9887@opensource.wolfsonmicro.com> X-Cookie: The end of labor is to gain leisure. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] ASoC: wm_adsp: Add basic debugfs entries X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1426 Lines: 39 --wyYQCv9VYpiQX0rh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 09, 2015 at 01:06:41PM +0100, Richard Fitzgerald wrote: > On Mon, Jun 08, 2015 at 06:40:41PM +0100, Mark Brown wrote: > > Why are we adding this init to every individual CODEC rather than doing > > it when we initialize the DSP (which there are calls for already)? > Because we call the existing wm_adsp_init() early in probe and at that point we > haven't registered the codec yet. Can you not either hang it off the device or move the registration later? --wyYQCv9VYpiQX0rh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVdwsQAAoJECTWi3JdVIfQAZQH/3oG297I1WqwEePg4l030Go9 P7gLXaUs6MH+OrJSGB9D7n/s/BQmBLCZaH6x/f5JiPSXvJE0wt+P2OWJLBrTDgAb gl7j5cGyz+nc+K4uLCzDaCsnEBqLqJVHxjj2B4rTTtw0olaRTSVswhydNFsKUV1w GxQaIOeNeErqiX14rvHBVPD26ErPQfWjiER/gUoGwXSuAJ+hoX7oe9FTMK8efoXi Cqh7QWAc3tp8TIBFQa3qz9J/oD9jOFO8/Lm9LIj+Tp9gukv+m4q6583gOnh4ONK0 QUOUBx4C4EVPDjK5SkCv3UK/wsBzCm8F3/JV/smOWOQb1y55f1WloTtm6AUlcpo= =lMan -----END PGP SIGNATURE----- --wyYQCv9VYpiQX0rh-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/