Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932487AbbFIPxt (ORCPT ); Tue, 9 Jun 2015 11:53:49 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:44127 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752106AbbFIPxl (ORCPT ); Tue, 9 Jun 2015 11:53:41 -0400 X-Originating-IP: 83.155.44.161 Message-ID: <1433865182.5707.7.camel@hadess.net> Subject: Re: [PATCH v2 4/8] input: goodix: reset device at init From: Bastien Nocera To: Irina Tirdea Cc: Dmitry Torokhov , Mark Rutland , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Octavian Purdila Date: Tue, 09 Jun 2015 17:53:02 +0200 In-Reply-To: <1433864084.5707.4.camel@hadess.net> References: <1433774273-23103-1-git-send-email-irina.tirdea@intel.com> <1433774273-23103-5-git-send-email-irina.tirdea@intel.com> <1433864084.5707.4.camel@hadess.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.2.1 (3.16.2.1-1.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1287 Lines: 30 On Tue, 2015-06-09 at 17:34 +0200, Bastien Nocera wrote: > On Mon, 2015-06-08 at 17:37 +0300, Irina Tirdea wrote: > > After power on, it is recommended that the driver resets the > > device. > > The reset procedure timing is described in the datasheet and is > > used > > at device init (before writing device configuration) and > > for power management. It is a sequence of setting the interrupt > > and reset pins high/low at specific timing intervals. This > > procedure > > also includes setting the slave address to the one specified in the > > ACPI/device tree. > > This breaks the touchscreen on my Onda v975w: > [ 239.732858] Goodix-TS i2c-GDIX1001:00: ID 9271, version: 1020 > [ 239.732977] Goodix-TS i2c-GDIX1001:00: Failed to get reset GPIO: > -16 > [ 239.736071] Goodix-TS: probe of i2c-GDIX1001:00 failed with error > -16 > > This is the DSDT for that device: > https://bugzilla.kernel.org/attachment.cgi?id=149331 (Note that this means that I haven't been able to test any following patches in that series than 4/8). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/