Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933135AbbFIQBI (ORCPT ); Tue, 9 Jun 2015 12:01:08 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:50446 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933025AbbFIQAw (ORCPT ); Tue, 9 Jun 2015 12:00:52 -0400 Date: Tue, 9 Jun 2015 17:00:43 +0100 From: Mark Brown To: Richard Fitzgerald Cc: lgirdwood@gmail.com, patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Message-ID: <20150609160043.GD14071@sirena.org.uk> References: <1433863017-25349-1-git-send-email-rf@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3RfTNxEu1XWqbbj+" Content-Disposition: inline In-Reply-To: <1433863017-25349-1-git-send-email-rf@opensource.wolfsonmicro.com> X-Cookie: The end of labor is to gain leisure. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2 1/2] ASoC: wm_adsp: Add code_probe and codec_remove stubs X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1293 Lines: 38 --3RfTNxEu1XWqbbj+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 09, 2015 at 04:16:56PM +0100, Richard Fitzgerald wrote: > + ret = wm_adsp2_codec_probe(&priv->core.adsp[0], codec); > + if (ret) > + return ret; > + I'm still not a big fan of the double registration that's being done - if nothing else the fact that it's not also factoring out the creation of the DSP controls seems wrong. --3RfTNxEu1XWqbbj+ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVdw2qAAoJECTWi3JdVIfQIP8H/RIowccXd0z4EMqmYUPVNqNH QnHqeeBzJkUywYXnV2uKXEHa2vG5F9p6Bcd3uykKM0v8Lo/xtqTwYiEJTMlkbVd/ O0Z2v1WaRFgolDEBwx5qMyiD5gZfggTzNVRb3cvEzY/jRE8XOv5pEBvqMJVuz3Qx +MDpVPdlTp0BdyMP/p16oswQaOpnIgwu2ooLm3yR/7Mx9HJLxYj8xUu/gYN8RQjh qf2aS0ceRMcp2ZbRTYi7Iu/NvHpugal9ZHpwPxG3d0h6yzlME/f2/2FCbqBr/p0A 6BhibaTQv6ndlcZFTVzMqe2uyy719sFPUu7g647HRYEOhiTxQ/xQ+oXzdb7iSAs= =uxhP -----END PGP SIGNATURE----- --3RfTNxEu1XWqbbj+-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/