Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753929AbbFIQF4 (ORCPT ); Tue, 9 Jun 2015 12:05:56 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:51100 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750868AbbFIQFy (ORCPT ); Tue, 9 Jun 2015 12:05:54 -0400 Message-ID: <55770EA6.8020908@atmel.com> Date: Tue, 9 Jun 2015 18:04:54 +0200 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Cyrille Pitchen , , , CC: , , , , , , , Subject: Re: [PATCH v5 3/6] i2c: at91: update documentation for DT bindings References: In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2754 Lines: 85 Le 03/06/2015 18:25, Cyrille Pitchen a ?crit : > add a new value "atmel,at91sama5d2-i2c" for the "compatible" property. Well, here I would like "atmel,sama5d2-i2c" like any other "SAMA5" product compatibility string out there... Aka NAK for me ;-) > add a new optional property "atmel,fifo-size" to enable FIFO support when > available. > add missing optional properties "dmas" and "dma-names". > > Signed-off-by: Cyrille Pitchen > --- > Documentation/devicetree/bindings/i2c/i2c-at91.txt | 29 ++++++++++++++++++++-- > 1 file changed, 27 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-at91.txt b/Documentation/devicetree/bindings/i2c/i2c-at91.txt > index 388f0a2..7c04fd9 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-at91.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c-at91.txt > @@ -2,8 +2,8 @@ I2C for Atmel platforms > > Required properties : > - compatible : Must be "atmel,at91rm9200-i2c", "atmel,at91sam9261-i2c", > - "atmel,at91sam9260-i2c", "atmel,at91sam9g20-i2c", "atmel,at91sam9g10-i2c" > - or "atmel,at91sam9x5-i2c" > + "atmel,at91sam9260-i2c", "atmel,at91sam9g20-i2c", "atmel,at91sam9g10-i2c", > + "atmel,at91sam9x5-i2c" or "atmel,at91sama5d2-i2c" Ditto > - reg: physical base address of the controller and length of memory mapped > region. > - interrupts: interrupt number to the cpu. > @@ -13,6 +13,9 @@ Required properties : > > Optional properties: > - clock-frequency: Desired I2C bus frequency in Hz, otherwise defaults to 100000 > +- dmas: A list of two dma specifiers, one for each entry in dma-names. > +- dma-names: should contain "tx" and "rx". > +- atmel,fifo-size: size of the RX and TX FIFOs, if available. > - Child nodes conforming to i2c bus binding > > Examples : > @@ -32,3 +35,25 @@ i2c0: i2c@fff84000 { > pagesize = <128>; > } > } > + > +i2c0: i2c@f8034600 { > + compatible = "atmel,at91sama5d2-i2c"; Ditto > + reg = <0xf8034600 0x100>; > + interrupts = <19 IRQ_TYPE_LEVEL_HIGH 7>; > + dmas = <&dma0 > + (AT91_XDMAC_DT_MEM_IF(0) | AT91_XDMAC_DT_PER_IF(1)) > + AT91_XDMAC_DT_PERID(11)>, > + <&dma0 > + (AT91_XDMAC_DT_MEM_IF(0) | AT91_XDMAC_DT_PER_IF(1)) > + AT91_XDMAC_DT_PERID(12)>; > + dma-names = "tx", "rx"; > + #address-cells = <1>; > + #size-cells = <0>; > + clocks = <&flx0>; > + atmel,fifo-size = <32>; > + > + wm8731: wm8731@1a { > + compatible = "wm8731"; > + reg = <0x1a>; > + }; > +}; > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/