Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933105AbbFIQOI (ORCPT ); Tue, 9 Jun 2015 12:14:08 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:34423 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753541AbbFIQOC (ORCPT ); Tue, 9 Jun 2015 12:14:02 -0400 Date: Tue, 9 Jun 2015 17:13:56 +0100 From: Richard Fitzgerald To: Mark Brown Cc: lgirdwood@gmail.com, patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] ASoC: wm_adsp: Add code_probe and codec_remove stubs Message-ID: <20150609161356.GB27675@opensource.wolfsonmicro.com> References: <1433863017-25349-1-git-send-email-rf@opensource.wolfsonmicro.com> <20150609160043.GD14071@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150609160043.GD14071@sirena.org.uk> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 850 Lines: 20 On Tue, Jun 09, 2015 at 05:00:43PM +0100, Mark Brown wrote: > On Tue, Jun 09, 2015 at 04:16:56PM +0100, Richard Fitzgerald wrote: > > > + ret = wm_adsp2_codec_probe(&priv->core.adsp[0], codec); > > + if (ret) > > + return ret; > > + > > I'm still not a big fan of the double registration that's being done - > if nothing else the fact that it's not also factoring out the creation > of the DSP controls seems wrong. I don't see the point of trying to fight against the design of ASoC with the second probe. ASoC gives us what we need at the codec_probe stage so why try to invent something different? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/