Message-ID: <1433867003.3165.64.camel@stgolabs.net>
Subject: Re: [PATCH -next] selftests/ipc: Consolidate posix and sysv msg
 queue tests
From: Davidlohr Bueso <dave@stgolabs.net>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Date: Tue, 09 Jun 2015 09:23:23 -0700
In-Reply-To: <5576E25E.40600@osg.samsung.com>
References: <1433807517.3165.32.camel@stgolabs.net>
	 <5576E25E.40600@osg.samsung.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2069
Lines: 61

On Tue, 2015-06-09 at 06:55 -0600, Shuah Khan wrote
> > diff --git a/tools/testing/selftests/ipc/.gitignore b/tools/testing/selftests/ipc/.gitignore
> > new file mode 100644
> > index 0000000..3d8a449
> > --- /dev/null
> > +++ b/tools/testing/selftests/ipc/.gitignore
> > @@ -0,0 +1,3 @@
> > +mqueue/mq_open_tests
> > +mqueue/mq_perf_tests
> > +msg/msgque_test
> > diff --git a/tools/testing/selftests/ipc/Makefile b/tools/testing/selftests/ipc/Makefile
> > index 25d2e70..8686551 100644
> > --- a/tools/testing/selftests/ipc/Makefile
> > +++ b/tools/testing/selftests/ipc/Makefile
> > @@ -1,22 +1,22 @@
> > -uname_M := $(shell uname -m 2>/dev/null || echo not)
> > -ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/)
> > -ifeq ($(ARCH),i386)
> > -        ARCH := x86
> > -	CFLAGS := -DCONFIG_X86_32 -D__i386__
> > -endif
> > -ifeq ($(ARCH),x86_64)
> > -	ARCH := x86
> > -	CFLAGS := -DCONFIG_X86_64 -D__x86_64__
> > -endif
> > -
> > -CFLAGS += -I../../../../usr/include/
> 
> Hmm. This looks like more than a moving code and cleanup change.
> The above is removing special handling for x86 and x86_64.
> 
> I would like to see this as a separate patch and not combined
> with the moving code.

No, this is merely being moved to msg/Makefile, see below:

> diff --git a/tools/testing/selftests/ipc/msg/Makefile b/tools/testing/selftests/ipc/msg/Makefile
> new file mode 100644
> index 0000000..777ca76
> --- /dev/null
> +++ b/tools/testing/selftests/ipc/msg/Makefile
> @@ -0,0 +1,22 @@
> +uname_M := $(shell uname -m 2>/dev/null || echo not)
> +ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/i386/)
> +ifeq ($(ARCH),i386)
> +        ARCH := x86
> +     CFLAGS := -DCONFIG_X86_32 -D__i386__
> +endif
> +ifeq ($(ARCH),x86_64)
> +     ARCH := x86
> +     CFLAGS := -DCONFIG_X86_64 -D__x86_64__
> +endif

Thanks,
Davidlohr

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/