Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754134AbbFIRAB (ORCPT <rfc822;w@1wt.eu>);
	Tue, 9 Jun 2015 13:00:01 -0400
Received: from smtp.codeaurora.org ([198.145.29.96]:38753 "EHLO
	smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753167AbbFIQ7x (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 9 Jun 2015 12:59:53 -0400
Message-ID: <55771B86.4050708@codeaurora.org>
Date: Tue, 09 Jun 2015 10:59:50 -0600
From: Jeffrey Hugo <jhugo@codeaurora.org>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Lina Iyer <lina.iyer@linaro.org>, ohad@wizery.com
CC: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Andy Gross <agross@codeaurora.org>
Subject: Re: [PATCH RFC v2 1/2] hwspinlock: Introduce raw capability for hwspinlocks
References: <1433867020-7746-1-git-send-email-lina.iyer@linaro.org> <1433867020-7746-2-git-send-email-lina.iyer@linaro.org>
In-Reply-To: <1433867020-7746-2-git-send-email-lina.iyer@linaro.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 955
Lines: 26

Two minor nits I noticed.

On 6/9/2015 10:23 AM, Lina Iyer wrote:
> The hwspinlock framework, uses a s/w spin lock around the hw spinlock to
> ensure that only process acquires the lock at any time. This is the most

Should this be "ensure that only one process"?

<snip>

> Introduce hwcaps member for hwspinlock_device. The hwcaps represents the

Technically you added it to the hwspinlock struct, not 
hwspinlock_device.  Mentioning that the hwcaps member was added to 
hwspinlock_device in the description here may be slightly confusing.

-- 
Jeffrey Hugo
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum, a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/