Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753860AbbFIRQW (ORCPT ); Tue, 9 Jun 2015 13:16:22 -0400 Received: from domu-toccata.ens-lyon.fr ([140.77.166.138]:53155 "EHLO sonata.ens-lyon.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbbFIRQO (ORCPT ); Tue, 9 Jun 2015 13:16:14 -0400 Date: Tue, 9 Jun 2015 19:16:07 +0200 From: Samuel Thibault To: Dmitry Torokhov Cc: Pavel Machek , Pali =?iso-8859-1?Q?Roh=E1r?= , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, rpurdie@rpsys.net, Greg Kroah-Hartman Subject: Re: [PATCH 1/3] Input: export LEDs as class devices in sysfs Message-ID: <20150609171607.GA4336@type.youpi.perso.aquilenet.fr> Mail-Followup-To: Samuel Thibault , Dmitry Torokhov , Pavel Machek , Pali =?iso-8859-1?Q?Roh=E1r?= , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, rpurdie@rpsys.net, Greg Kroah-Hartman References: <1433799790-31873-1-git-send-email-dmitry.torokhov@gmail.com> <1433799790-31873-2-git-send-email-dmitry.torokhov@gmail.com> <20150609131955.GA3045@type> <20150609132734.GA3132@type> <20150609165052.GE6338@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150609165052.GE6338@dtor-ws> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 935 Lines: 22 Dmitry Torokhov, le Tue 09 Jun 2015 09:50:52 -0700, a ?crit : > On Tue, Jun 09, 2015 at 03:27:34PM +0200, Samuel Thibault wrote: > > Samuel Thibault, le Tue 09 Jun 2015 15:19:55 +0200, a ?crit : > > > > + [LED_NUML] = { "num-lock", VT_TRIGGER("kbd-numlock") }, > > > > + [LED_CAPSL] = { "caps-lock", VT_TRIGGER("kbd-capslock") }, > > > > + [LED_SCROLLL] = { "scroll-lock", VT_TRIGGER("kbd-scrollock") }, > > > > > > I'd tend to think we'd want to harmonize the user-visible LED names and > > > kbd trigger names, > > > > And perhaps fix that odd-looking "scrollock"? > > If you are talking about LED_SCROLLL I mean kbd-scrollock in the above code which looks like a typo to me. Samuel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/