MIME-Version: 1.0
In-Reply-To: <1433869251.26331.114.camel@linux.intel.com>
References: <1433848247-3550-1-git-send-email-kuleshovmail@gmail.com>
	<1433848301-5296-1-git-send-email-kuleshovmail@gmail.com>
	<1433869251.26331.114.camel@linux.intel.com>
Date: Wed, 10 Jun 2015 00:00:43 +0600
Message-ID: <CANCZXo7r+7hP+wGGmtdnWnvZ8zWKn8VtkX4hYiEx7VdD2EAgTQ@mail.gmail.com>
Subject: Re: [PATCH v11 4/5] x86/earlyprintk: setup earlyprintk as early as possible
From: Alexander Kuleshov <kuleshovmail@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, LKML <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Borislav Petkov <bp@suse.de>, Mark Rustad <mark.d.rustad@intel.com>,
        Yinghai Lu <yinghai@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 965
Lines: 34

2015-06-09 23:00 GMT+06:00 Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
>
> I'm still not convincing by this code to be in that form and here. What
> about to refactor setup_early_printk() to helper which will do parse
> parameters to a let say structure where one of the flag will be
> struct early_printk_param {
> …
> const char *arg;
> bool serial;
> }
>
> Your function will be something like this
>
> struct early_printk_param epp;
>
> parse_early_printk_param(&epp);
>
> if (!epp->serial)
>  return /* whatever error code */;
>
> return setup_early_printk(epp.arg);
>

Hello Andy,

But what is difference between parsing to string and
passing it and parsing to structure and pass its field?

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/