Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754058AbbFISow (ORCPT ); Tue, 9 Jun 2015 14:44:52 -0400 Received: from down.free-electrons.com ([37.187.137.238]:49276 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752335AbbFISoo (ORCPT ); Tue, 9 Jun 2015 14:44:44 -0400 Date: Tue, 9 Jun 2015 20:44:39 +0200 From: Boris Brezillon To: Rob Herring Cc: Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arm@kernel.org, Mike Turquette , Stephen Boyd , linux-clk@vger.kernel.org Subject: Re: [PATCH 03/15] clk: kill off set_irq_flags usage Message-ID: <20150609204439.1461f02b@bbrezillon> In-Reply-To: <1433874401-27161-4-git-send-email-robh@kernel.org> References: <1433874401-27161-1-git-send-email-robh@kernel.org> <1433874401-27161-4-git-send-email-robh@kernel.org> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1911 Lines: 54 On Tue, 9 Jun 2015 13:26:29 -0500 Rob Herring wrote: > set_irq_flags is ARM specific with custom flags which have genirq > equivalents. Convert drivers to use the genirq interfaces directly, so we > can kill off set_irq_flags. The translation of flags is as follows: > > IRQF_VALID -> !IRQ_NOREQUEST > IRQF_PROBE -> !IRQ_NOPROBE > IRQF_NOAUTOEN -> IRQ_NOAUTOEN > > For IRQs managed by an irqdomain, the irqdomain core code handles clearing > and setting IRQ_NOREQUEST already, so there is no need to do this in > .map() functions and we can simply remove the set_irq_flags calls. Some > users also set IRQ_NOPROBE and this has been maintained although it is not > clear that is really needed. There appears to be a great deal of blind > copy and paste of this code. > > Signed-off-by: Rob Herring Acked-by: Boris Brezillon > Cc: Boris Brezillon > Cc: Mike Turquette > Cc: Stephen Boyd > Cc: linux-clk@vger.kernel.org > --- > drivers/clk/at91/pmc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c > index 3f27d21..828b196 100644 > --- a/drivers/clk/at91/pmc.c > +++ b/drivers/clk/at91/pmc.c > @@ -125,7 +125,6 @@ static int pmc_irq_map(struct irq_domain *h, unsigned int virq, > > irq_set_chip_and_handler(virq, &pmc_irq, > handle_level_irq); > - set_irq_flags(virq, IRQF_VALID); > irq_set_chip_data(virq, pmc); > > return 0; -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/