Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933291AbbFISwZ (ORCPT ); Tue, 9 Jun 2015 14:52:25 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:50261 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933269AbbFISwP (ORCPT ); Tue, 9 Jun 2015 14:52:15 -0400 Date: Tue, 9 Jun 2015 11:52:12 -0700 From: Stephen Boyd To: Rob Herring Cc: Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arm@kernel.org, Boris Brezillon , Mike Turquette , linux-clk@vger.kernel.org Subject: Re: [PATCH 03/15] clk: kill off set_irq_flags usage Message-ID: <20150609185212.GB29640@codeaurora.org> References: <1433874401-27161-1-git-send-email-robh@kernel.org> <1433874401-27161-4-git-send-email-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433874401-27161-4-git-send-email-robh@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1383 Lines: 33 On 06/09, Rob Herring wrote: > set_irq_flags is ARM specific with custom flags which have genirq > equivalents. Convert drivers to use the genirq interfaces directly, so we > can kill off set_irq_flags. The translation of flags is as follows: > > IRQF_VALID -> !IRQ_NOREQUEST > IRQF_PROBE -> !IRQ_NOPROBE > IRQF_NOAUTOEN -> IRQ_NOAUTOEN > > For IRQs managed by an irqdomain, the irqdomain core code handles clearing > and setting IRQ_NOREQUEST already, so there is no need to do this in > .map() functions and we can simply remove the set_irq_flags calls. Some > users also set IRQ_NOPROBE and this has been maintained although it is not > clear that is really needed. There appears to be a great deal of blind > copy and paste of this code. > > Signed-off-by: Rob Herring > Cc: Boris Brezillon > Cc: Mike Turquette > Cc: Stephen Boyd > Cc: linux-clk@vger.kernel.org > --- Acked-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/