Date: Tue, 9 Jun 2015 21:28:34 +0100
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Rob Herring <robh@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        arm@kernel.org, Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.cz>, Barry Song <baohua@kernel.org>,
        Simon Horman <horms@verge.net.au>, Magnus Damm <magnus.damm@gmail.com>,
        Tomasz Figa <tomasz.figa@gmail.com>,
        Thomas Abraham <thomas.abraham@linaro.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Samuel Ortiz <sameo@linux.intel.com>, Lee Jones <lee.jones@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Roger Quadros <rogerq@ti.com>, Tony Lindgren <tony@atomide.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>, David Airlie <airlied@linux.ie>,
        Alexandre Courbot <gnurou@gmail.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Vinod Koul <vinod.koul@intel.com>,
        Mike Turquette <mturquette@linaro.org>,
        Stephen Boyd <sboyd@codeaurora.org>, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 00/15] Kill off set_irq_flags
Message-ID: <20150609202834.GH7557@n2100.arm.linux.org.uk>
References: <1433874401-27161-1-git-send-email-robh@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1433874401-27161-1-git-send-email-robh@kernel.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1286
Lines: 27

On Tue, Jun 09, 2015 at 01:26:26PM -0500, Rob Herring wrote:
> This series converts all users of ARM specific set_irq_flags to use
> common genirq functions. In many cases where irqdomains are used, the
> set_irq_flags calls were redundant, so I've removed them.
> 
> This is not intended for 4.2, but if any subsystem maintainers want to
> pick up their subsystem's change that is fine. All but the last 2
> patches stand on their own. Any new drivers going into 4.2 may need a
> similar change, but I'm sure people are told not to use set_irq_flags in
> reviews. ;)

So what are you doing about the initial state of IRQs on legacy ARM where
IRQs start off being un-requestable, and need the set_irq_flags() to make
them requestable.  I think you could be introducing a massive regression
by making this change.

Unless you can prove that this isn't the case, you shouldn't be removing
this stuff, especially not from legacy platforms.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/