Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753474AbbFIU3R (ORCPT ); Tue, 9 Jun 2015 16:29:17 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33547 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752246AbbFIU3J (ORCPT ); Tue, 9 Jun 2015 16:29:09 -0400 Date: Tue, 9 Jun 2015 13:29:08 -0700 From: Andrew Morton To: Zhu Guihua Cc: , , , , , , , Subject: Re: [PATCH] mm/memory hotplug: print the last vmemmap region at the end of hot add memory Message-Id: <20150609132908.c5a9d2c9714bd7a8f33ffde8@linux-foundation.org> In-Reply-To: <55766068.9090809@cn.fujitsu.com> References: <1433745881-7179-1-git-send-email-zhugh.fnst@cn.fujitsu.com> <20150608163053.c481d9a5057513130f760910@linux-foundation.org> <55766068.9090809@cn.fujitsu.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1229 Lines: 35 On Tue, 9 Jun 2015 11:41:28 +0800 Zhu Guihua wrote: > >> --- a/mm/memory_hotplug.c > >> +++ b/mm/memory_hotplug.c > >> @@ -513,6 +513,7 @@ int __ref __add_pages(int nid, struct zone *zone, unsigned long phys_start_pfn, > >> break; > >> err = 0; > >> } > >> + vmemmap_populate_print_last(); > >> > >> return err; > >> } > > vmemmap_populate_print_last() is only available on x86_64, when > > CONFIG_SPARSEMEM_VMEMMAP=y. Are you sure this won't break builds? > > I tried this on i386 and on x86_64 when CONFIG_SPARSEMEM_VMEMMAP=n , > it builds ok. With powerpc: akpm3:/usr/src/25> make allmodconfig akpm3:/usr/src/25> make mm/memory_hotplug.o akpm3:/usr/src/25> nm mm/memory_hotplug.o | grep vmemmap_populate_print_last U .vmemmap_populate_print_last akpm3:/usr/src/25> grep -r vmemmap_populate_print_last arch/powerpc akpm3:/usr/src/25> So I think that's going to break. I expect ia64 will break also, but I didn't investigate. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/