Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932777AbbFIVR1 (ORCPT ); Tue, 9 Jun 2015 17:17:27 -0400 Received: from cantor2.suse.de ([195.135.220.15]:60858 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753110AbbFIVRS (ORCPT ); Tue, 9 Jun 2015 17:17:18 -0400 Date: Wed, 10 Jun 2015 07:17:06 +1000 From: Neil Brown To: Rasmus Villemoes Cc: Andrew Morton , Joe Perches , Al Viro , linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 6/8] drivers/md/md.c: Use strreplace Message-ID: <20150610071706.58ddc72e@home.neil.brown.name> In-Reply-To: <1433806017-10823-7-git-send-email-linux@rasmusvillemoes.dk> References: <1433806017-10823-1-git-send-email-linux@rasmusvillemoes.dk> <1433806017-10823-7-git-send-email-linux@rasmusvillemoes.dk> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; i586-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1367 Lines: 47 On Tue, 9 Jun 2015 01:26:54 +0200 Rasmus Villemoes wrote: > There's no point in starting over when we meet a '/'. This also > eliminates a stack variable and a little .text. > > Signed-off-by: Rasmus Villemoes > --- > v2: no changes. > > drivers/md/md.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/md/md.c b/drivers/md/md.c > index 27506302eb7a..2ea2f28551c5 100644 > --- a/drivers/md/md.c > +++ b/drivers/md/md.c > @@ -2024,7 +2024,6 @@ static int bind_rdev_to_array(struct md_rdev > *rdev, struct mddev *mddev) { > char b[BDEVNAME_SIZE]; > struct kobject *ko; > - char *s; > int err; > > /* prevent duplicates */ > @@ -2070,8 +2069,7 @@ static int bind_rdev_to_array(struct md_rdev > *rdev, struct mddev *mddev) return -EBUSY; > } > bdevname(rdev->bdev,b); > - while ( (s=strchr(b, '/')) != NULL) > - *s = '!'; > + strreplace(b, '/', '!'); > > rdev->mddev = mddev; > printk(KERN_INFO "md: bind<%s>\n", b); Acked-by: NeilBrown I'm happy for Andrew to merge this. Thanks, NeilBrown -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/