Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753867AbbFIVWc (ORCPT ); Tue, 9 Jun 2015 17:22:32 -0400 Received: from mail-ig0-f181.google.com ([209.85.213.181]:35226 "EHLO mail-ig0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752557AbbFIVWZ (ORCPT ); Tue, 9 Jun 2015 17:22:25 -0400 Date: Tue, 9 Jun 2015 15:22:22 -0600 From: Tycho Andersen To: Oleg Nesterov , Kees Cook , Andy Lutomirski Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Kees Cook , Andy Lutomirski , Will Drewry , Roland McGrath , Pavel Emelyanov , "Serge E. Hallyn" Subject: Re: [PATCH v2] seccomp: add ptrace options for suspend/resume Message-ID: <20150609212222.GE2045@hopstrocity> References: <1433369396-13360-1-git-send-email-tycho.andersen@canonical.com> <20150604183149.GA560@redhat.com> <20150604210529.GJ3160@smitten> <20150605211650.GA25718@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150605211650.GA25718@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1340 Lines: 41 Hi Kees, Andy, On Fri, Jun 05, 2015 at 11:16:50PM +0200, Oleg Nesterov wrote: > Hi Tycho, > > On 06/04, Tycho Andersen wrote: > > > > +#ifdef CONFIG_CHECKPOINT_RESTORE > > > > +bool may_suspend_seccomp(void) > > > > +{ > > > > + if (!capable(CAP_SYS_ADMIN)) > > > > + return false; > > > > + > > > > + if (current->seccomp.mode != SECCOMP_MODE_DISABLED) > > > > + return false; > > > > > > Heh. OK, I won't argue with the new check too ;) > > > > Actually now that I think about it I agree with you, these checks > > don't seem necessary. Even inside a user namespace, if you can ptrace > > a process you can make it do whatever you want irrespective of > > seccomp, as long as it has the necessary capabilities. Once the > > seccomp checks are run after ptrace, they'll be enforced so you > > couldn't have it call whatever you want in the first place. > > Good ;) > > > Still, perhaps I'm missing something... > > Kees, Andy? Any thoughts on removing may_suspend_seccomp() all together? I sent v3 with this still in it, but I can send v4 without it if we are all in agreement. Tycho -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/