Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753793AbbFIWTz (ORCPT ); Tue, 9 Jun 2015 18:19:55 -0400 Received: from sauhun.de ([89.238.76.85]:44522 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751583AbbFIWTs (ORCPT ); Tue, 9 Jun 2015 18:19:48 -0400 Date: Wed, 10 Jun 2015 07:19:37 +0900 From: Wolfram Sang To: Nicolas Ferre Cc: Cyrille Pitchen , ludovic.desroches@atmel.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, robh+dt@kernel.org Subject: Re: [PATCH v5 4/6] i2c: at91: add support for new alternative command mode Message-ID: <20150609221936.GB1717@katana> References: <55770F43.7050707@atmel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IrhDeMKUP4DT/M7F" Content-Disposition: inline In-Reply-To: <55770F43.7050707@atmel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1647 Lines: 51 --IrhDeMKUP4DT/M7F Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Nicolas, > > +static struct at91_twi_pdata at91sama5d2_config =3D { >=20 > No, please name it: >=20 > "sama5d2_config" Thanks for your input, but please don't quote the whole mail for those tiny comments. Only the relevant parts, please. Otherwise it is too easy to miss things. Thanks, Wolfram --IrhDeMKUP4DT/M7F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVd2Z4AAoJEBQN5MwUoCm2zLwP/3IUFrUV5eVlXXFN0C8IDyhB 153m/8dwwofNJ4eCehpGT/fP59YpdxfYpLgOM6oBkr+Ckqbw73hyxzZLmovp7Vm6 LSg/rIUBZh6U3GzA5m5CyqqxVsY7qAPWBi1rdMHMSVkpTJiVO22DmqZNejEFl5AU ale9oD653LHnhqtvkHc1lr6sJ4t8d193I18vCJN2P4k63DJRRqtKspkqz/oHwNxF ZzBNfR41BdQzbeGvUoY7hN3lXwBqSDLabqlAeVCh/FPKcJRGGiYS+RS9WOvtUfw3 wg+BMTKNOADvqnKXEY7nvgW85d/jBjcDRwJCiz6ndXU7O2ibyMJIVkTnfmR0k3t8 D08UDb76CsUJwSYDSzbCvQNZLhEtlsnL72mujEUhNHsVAKOjcvLQcgX6nkslKcLL ChI57gEfPaviPaWQuVWvSL9+ooCu2RuPc4cSGN2HDh7wOolxZYj+5UMCFhkPUsS6 2UWfNz+yw6fRMUS7ieDJj0U/uI0vc+bK5wxz1n6jea/qQUSPUzQbwb86ChlpHz/c 1AvsF1V67DM3dK7imS4lpSmBvb7o41Rxs9vJS7BbA//xex7dX8Z99yXBLX4xPxk0 t3RTBbUSOhAPxZgu35pKfo7d5Hl3boyJ+eEhrlJlEfYmSiNc57ThtrosAdFpl/5p 7SUreW2FQaER3Fw4qFIv =22K8 -----END PGP SIGNATURE----- --IrhDeMKUP4DT/M7F-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/