Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753413AbbFIW1T (ORCPT ); Tue, 9 Jun 2015 18:27:19 -0400 Received: from mail-wg0-f47.google.com ([74.125.82.47]:33871 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751748AbbFIW1K (ORCPT ); Tue, 9 Jun 2015 18:27:10 -0400 MIME-Version: 1.0 In-Reply-To: <20150609063312.GA9804@lst.de> References: <20150602001134.4506.45867.stgit@dwillia2-desk3.amr.corp.intel.com> <20150602001419.4506.41953.stgit@dwillia2-desk3.amr.corp.intel.com> <20150603145704.GA22311@lst.de> <1433359473.21035.27.camel@intel.com> <20150609063312.GA9804@lst.de> Date: Tue, 9 Jun 2015 15:27:09 -0700 Message-ID: Subject: Re: [PATCH v5 02/21] libnvdimm, nfit: initial libnvdimm infrastructure and NFIT support From: Dan Williams To: "hch@lst.de" Cc: "linux-kernel@vger.kernel.org" , "mingo@kernel.org" , "neilb@suse.de" , "jmoyer@redhat.com" , "linux-api@vger.kernel.org" , "axboe@kernel.dk" , "akpm@linux-foundation.org" , "sfr@canb.auug.org.au" , "linux-nvdimm@lists.01.org" , "gregkh@linuxfoundation.org" , "rafael@kernel.org" , "linux-acpi@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 940 Lines: 20 On Mon, Jun 8, 2015 at 11:33 PM, hch@lst.de wrote: > On Wed, Jun 03, 2015 at 07:24:34PM +0000, Williams, Dan J wrote: >> > > +static inline struct acpi_nfit_memory_map *__to_nfit_memdev(struct nfit_mem *nfit_mem) >> > >> > This line is over 80 characters. >> >> I generally don't see the point of fixing up occasional small incursions >> over 80 characters if it makes the code more amenable to grep. > > Just use shorter type names or add a line break before the symbol > names. Too long lines are highly annoying. Note that "acpi_nfit_memory_map" is the identifier chosen by ACPICA, I'm just a consumer. That said I've gone and done a 80 column cleanup across all the patches. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/