Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753963AbbFIW3G (ORCPT ); Tue, 9 Jun 2015 18:29:06 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35932 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932587AbbFIW2j (ORCPT ); Tue, 9 Jun 2015 18:28:39 -0400 Date: Tue, 9 Jun 2015 15:28:38 -0700 From: Andrew Morton To: Davidlohr Bueso Cc: Manfred Spraul , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Davidlohr Bueso Subject: Re: [PATCH 1/5] ipc,shm: move BUG_ON check into shm_lock Message-Id: <20150609152838.94774d7feafef3f7e6ccbd74@linux-foundation.org> In-Reply-To: <1433597880-8571-2-git-send-email-dave@stgolabs.net> References: <1433597880-8571-1-git-send-email-dave@stgolabs.net> <1433597880-8571-2-git-send-email-dave@stgolabs.net> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1728 Lines: 56 On Sat, 6 Jun 2015 06:37:56 -0700 Davidlohr Bueso wrote: > Upon every shm_lock call, we BUG_ON if an error was returned, > indicating racing either in idr or in shm_destroy. Move this logic > into the locking. > > --- a/ipc/shm.c > +++ b/ipc/shm.c > @@ -155,8 +155,14 @@ static inline struct shmid_kernel *shm_lock(struct ipc_namespace *ns, int id) > { > struct kern_ipc_perm *ipcp = ipc_lock(&shm_ids(ns), id); > > - if (IS_ERR(ipcp)) > + if (IS_ERR(ipcp)) { > + /* > + * We raced in the idr lookup or with shm_destroy(), > + * either way, the ID is busted. > + */ > + BUG(); > return (struct shmid_kernel *)ipcp; > + } Was there any particular reason to still do it this way? It's a bit klunky. --- a/ipc/shm.c~ipcshm-move-bug_on-check-into-shm_lock-fix +++ a/ipc/shm.c @@ -155,14 +155,11 @@ static inline struct shmid_kernel *shm_l { struct kern_ipc_perm *ipcp = ipc_lock(&shm_ids(ns), id); - if (IS_ERR(ipcp)) { - /* - * We raced in the idr lookup or with shm_destroy(), - * either way, the ID is busted. - */ - BUG(); - return (struct shmid_kernel *)ipcp; - } + /* + * We raced in the idr lookup or with shm_destroy(). Either way, the + * ID is busted. + */ + BUG_ON(IS_ERR(ipcp)); return container_of(ipcp, struct shmid_kernel, shm_perm); } One benefit of the code you sent is that the unreachable `return' will prevent a compile warning when CONFIG_BUG=n, but CONFIG_BUG=n is silly and I never worry about it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/