Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754073AbbFJAhM (ORCPT ); Tue, 9 Jun 2015 20:37:12 -0400 Received: from g4t3426.houston.hp.com ([15.201.208.54]:37102 "EHLO g4t3426.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753434AbbFJAhG (ORCPT ); Tue, 9 Jun 2015 20:37:06 -0400 From: "Elliott, Robert (Server Storage)" To: Dan Williams , "axboe@kernel.dk" CC: Michal Simek , Russell King , Greg Kroah-Hartman , Joerg Roedel , "linux-kernel@vger.kernel.org" , Julia Lawall , "dmaengine@vger.kernel.org" , David Woodhouse , "hch@lst.de" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH 1/2] scatterlist: use sg_phys() Thread-Topic: [PATCH 1/2] scatterlist: use sg_phys() Thread-Index: AQHQotHGCyoXLbgnk0ujNbjKBEjXQZ2k5I9g Date: Wed, 10 Jun 2015 00:34:57 +0000 Message-ID: <94D0CD8314A33A4D9D801C0FE68B40295A977F76@G9W0745.americas.hpqcorp.net> References: <20150609162659.21910.41681.stgit@dwillia2-desk3.amr.corp.intel.com> <20150609162710.21910.57295.stgit@dwillia2-desk3.amr.corp.intel.com> In-Reply-To: <20150609162710.21910.57295.stgit@dwillia2-desk3.amr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.210.192.232] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t5A0bFKq032042 Content-Length: 979 Lines: 27 > -----Original Message----- > From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel- > owner@vger.kernel.org] On Behalf Of Dan Williams > Sent: Tuesday, June 09, 2015 10:27 AM > Subject: [PATCH 1/2] scatterlist: use sg_phys() > ... > diff --git a/arch/microblaze/kernel/dma.c b/arch/microblaze/kernel/dma.c > index ed7ba8a11822..dcb3c594d626 100644 > --- a/arch/microblaze/kernel/dma.c > +++ b/arch/microblaze/kernel/dma.c > @@ -61,7 +61,7 @@ static int dma_direct_map_sg(struct device *dev, struct > scatterlist *sgl, > /* FIXME this part of code is untested */ > for_each_sg(sgl, sg, nents, i) { > sg->dma_address = sg_phys(sg); > - __dma_sync(page_to_phys(sg_page(sg)) + sg->offset, > + __dma_sync(sg_phys(sg), > sg->length, direction); > } That one ends up with weird indentation. ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?