Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754106AbbFJAlB (ORCPT ); Tue, 9 Jun 2015 20:41:01 -0400 Received: from mail-by2on0121.outbound.protection.outlook.com ([207.46.100.121]:23456 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751158AbbFJAkx (ORCPT ); Tue, 9 Jun 2015 20:40:53 -0400 Authentication-Results: solid-run.com; dkim=none (message not signed) header.d=none; Message-ID: <5577878B.1080402@freescale.com> Date: Tue, 9 Jun 2015 17:40:43 -0700 From: York Sun User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Michael Turquette , Guenter Roeck CC: , , , , , Subject: Re: clock driver References: <5564C58B.9050400@freescale.com> <20150526223829.GA26454@roeck-us.net> <55650DBA.5000304@freescale.com> <5565108D.2020502@freescale.com> <20150527173055.22384.74368@quantum> In-Reply-To: <20150527173055.22384.74368@quantum> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.88.168.50] X-ClientProxiedBy: SN1PR0701CA0015.namprd07.prod.outlook.com (25.162.96.25) To BY2PR03MB159.namprd03.prod.outlook.com (10.242.36.18) X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB159;2:fxbh3xl/f/s+ZqBOU6Aj6NaYG5FcBjcqHxt1fozYHbV81+By0t4+OxB5aP/ya/fg;2:KKpkvJqyMrV6Ok5mWiSQcpaLEJtYLm6T3HhiALUA7+8MMuR8k6Lsv5qo2kEfjqRKZ4oq79jS3X68yHb2+OdC1mucOoHqsXGp9ZgLMD6s1p8tbusQcQ6Tm5NxC1PnzgUgzsKiYOw0AuXSfxhm/MMrfA==;6:wYV8s1faPunxm5BSsdTza5FyIwX3BiSKkHL7+VifEoSCov1DixTGXXptIV904nPYg5W/qbEH66EiPtr7mYDZIr43jQbeeFpD8sIMcn5S7kHIjTFcvAibWcV7+HDs5hV4g3X880W5J2EVLlSL3DeH2S2ctg6Ms6n2/8m/k3mYv1VdMofWRCfUmSNLGHjeyVaYBI5JS3y71hxa3gUc0I2YXwoGakUBG/bXKfdpgTAiavkYvdIXpKMyI3CO5w6GFF2ek8Cms9hDlD0i2W4blB8CE4+weWS4o/n6zXvrxFLRXfgone72LzKwPtkNyKR1C5OovFWoy8PSNYvxeMHFNPgdGj1BZFvqjt7LVLkCCu4YgbIyoRwLgg3LpValNmH3eV4cjfvPOdi8hq4f4CYBSpIoFiZn8yxpr9R3C68zJKxvm6bA2NEQrPJza5sLx6ff2VbuThHXArGxPtRMNkZOP2klRndiVMSa+xagrMBkXubvM0VPoCP5SqFnMU/BiTH/XToLxcSjAmpkCgwcHWnyqilEb2alHrZFd4aRbAbWnFRYjG035G2t1K3NJDXfwWXgQBUh38cUiU1OFakiJ2mKSjepOZu/7rGeVY3LQf1BjJmGyg0= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB159; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(520003)(3002001);SRVR:BY2PR03MB159;BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB159; X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB159;3:KlPjQkmz9k30BrN01WRg8xQTKqKoNU/OPiOYguDxFJjN/C1Zy/SbIr9o4MEepD2Kr9b0wq+EA8Ybx0WcEK4bRuZlhBPjs4P/Mf8s2Z+LvgyKR/tqNlHZ4VBgVE+9tKq46FP0g221nfv3LPuAZh12fvH3Bst3K7Jt8LO41clIiemlkXm+0gytpIZ6toseHreQyrn0Y0iCv787XbDnAxmoOtv+4HL4u4gjsG7ATkT4Gy72nhaDz2t1mNH9qQfoX0r0baQW8JuBtkJv41of+OafCdWtDwEccfyzdFmKjm8JsT3JcsCkswFzBngMOkVZoM5f X-Forefront-PRVS: 06036BD506 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6049001)(6009001)(64126003)(93886004)(46102003)(47776003)(42186005)(80316001)(2950100001)(86362001)(189998001)(77096005)(50466002)(5001770100001)(5001960100002)(5001920100001)(92566002)(36756003)(23746002)(33656002)(122386002)(66066001)(76176999)(87266999)(65806001)(99136001)(65956001)(221733001)(77156002)(65816999)(87976001)(40100003)(54356999)(50986999)(111123002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR03MB159;H:[10.214.87.3];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB159;9:DE8ST9WiUnO2qZjUsDpVf/DTOAF07s7apEI99V5bA6DD2w4X5zSsQEVXiRpSdySMHppv9oWTuIfL/huWtqYUz9lNUnTSZ5m+liw2BAi0jebokiT6CSFrPJ5hTuIHl4R4mr+haI6GVuHwmgbdLCDX1WNXngkt7OMuXX1i1j2s86gEG94hJM/hqrmaE/eNbhLU61r4CQdLFWVN7LU7WE/2pzrIIxEROzVOolbU6wXghCMaWq8HxDFvzUHTfgp2uuXI/ny3huiA+qNMkmfLNwlqCho4YiiFLRPkuH98T6lOul7oNvqzFx2ZI1FBkML+/9vV1Fngui7w5qYzTcbGc1yzC0ygk1OCuFtguahgzFIw7RbTJE9D2AyngwioiyEtIjpNA/HlJLnG8vJByZ6jy6coYnaq/D+4mac1SOYa4KnIl7ThkG+HGcwflQfRhTrborvdAHxMJu09VVlCxM2jRvd5KmKl94kJVRMFOClzY/Owab98YcQrgL7g7mQ1UIppDOLAUJZ6dp2A++Hfez0Efu19/nJMUD6qqp+4lk05pQLofwTKSNYyPIjLw12tab7XuQqitCtZ/JXFiglBzmCfUfTtA6TtdHiR3B92jaxUKVKqmXUkpnTFwsUhvc+UjilHjhicgb5PeOFA1XrSkly6PgCrvAISF3ML0I/UE4spqT67v9v5aGQ6RCB4MUZWYvWJHTya/qCt2vYR/1XAG1Mn/f80OfTW2BLmKmHnq18f84wnKKDcbQw/TwDOogyU6R+5vIdwFGGgOk4wgEYY4+AGBrrPPHbR8RjYxe4I5YyyHuYxrOIiwP1QSyCOtjW5lTAOZlcORwcu34QkuCsX1CJ0baYRF2nk52to5FMx7DQ26TUimR/25xIHaa+sffST/WuTqCBaibLt9SI4JwRj9JlV3jW4CUrcbE1LTw8aHYmQjSLnoArBsPtpkSAo/7Hn6Q1UjCGH X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB159;3:xp5GIP3vb27xLQ42zTM4+OAfz6wsoCWquNG74bZJMHlfRT7NpRKbzCN0KTZqP/2MQBzuSknac6zbTG0MAeu54fZCb8wUqCRHTiNbOad+bcrAx3M0wSKq1jbh52QBZ4W5cHCO5s/SPFT2KK/lEI/+og==;10:l1bmunQJIrSR7qyUFHHoDHO2wxOvQQOXMyEkMrZx9z5vB97RyzGEiOxmpR/YJXkvRGN4rZJT7Fzjx+O9QMxNOXxKlj66JPPWgBePq/H0+Gc=;6:c6/p7oFJeQtpBZxkPWCnpsHfYRSOZa4j7JSB3+tIlQCX7g46qSo2bBEfpGnueWX1 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2015 00:40:49.7422 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR03MB159 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 912 Lines: 25 Michael, I have rewritten the driver to use CCF. It will be sent for review when ready. I have some questions, hoping you can shed some light on them. Q1: What does of_clk_add_provider do? I read the code and comment. It registers a clock provider for a node. How is it used after registration? Q2: What do you suggest to name multiple clocks on PCIe (FPGA) cards? I will have multiple cards with multiple clock chips on each. The clock driver can handle clocks on each chip. Is it recommended to create unique names by the driver? Is there any example to follow? Q3: Is there a guideline or an API to create sub folder under debugfs "clk"? Thanks a lot. York -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/