Message-ID: <1433901720.2477.105.camel@freescale.com>
Subject: Re: [PATCH v3] powerpc/cache: add cache flush operation for various
 e500
From: Scott Wood <scottwood@freescale.com>
To: Tang Yuantian-B29983 <Yuantian.Tang@freescale.com>
CC: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Zhao Chenhui-B35336" <chenhui.zhao@freescale.com>,
        Tang Yuantian <Yuantian.Tang@feescale.com>
Date: Tue, 9 Jun 2015 21:02:00 -0500
In-Reply-To: <DM2PR03MB574243DF3299029B2E67C97FABD0@DM2PR03MB574.namprd03.prod.outlook.com>
References: <1433814827-10431-1-git-send-email-Yuantian.Tang@freescale.com>
	,<1433888900.2477.104.camel@freescale.com>
	 <DM2PR03MB574243DF3299029B2E67C97FABD0@DM2PR03MB574.namprd03.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2015 02:02:08.7544
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1482
X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1484;2:tuUwz1Zv2EaNTLK/XALNv6kGMxODWF31LbjVXYn62jFidqiYsizgIVZSNoXaNKw2;2:HX74JaUcJH2XSisvPF1VUGGKeHejvIblb4CfWzfglRJ0p17rCbVnq6XpuPIMODsnwm6NS7XQeZH5GFN7w5F+qchbuPoGZUj/369wISvmv3z2UwpIYcZ9LEaQ5AoUQcB1Skmk5oUb92XP4eA4xxcU8Q==;9:2Xy1C0tTctstwl7GBxuHjFe6Wz47Meh/WXeu5G2KP2IkrQ/hAKdp/RUtRC96/dFBA9/rTstX0czZjkueWotoqzS7ZYbEGtg9T4+x2zLkWLwml0Mp1puO4gDN6X4OXIGS31BSEMrC2nH1hX1QIC1gdw==
X-OriginatorOrg: freescale.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2265
Lines: 55

On Tue, 2015-06-09 at 21:00 -0500, Tang Yuantian-B29983 wrote:
> Please see my replay inline.
> ________________________________________
> From: Wood Scott-B07421
> Sent: Wednesday, June 10, 2015 6:28 AM
> To: Tang Yuantian-B29983
> Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; 
> linux-kernel@vger.kernel.org; Zhao Chenhui-B35336; Tang Yuantian
> Subject: Re: [PATCH v3] powerpc/cache: add cache flush operation for 
> various e500
> 
> On Tue, 2015-06-09 at 09:53 +0800,  Yuantian.Tang@freescale.comwrote:
> > From: Tang Yuantian <Yuantian.Tang@freescale.com>
> > 
> > Various e500 core have different cache architecture, so they
> > need different cache flush operations. Therefore, add a callback
> > function cpu_flush_caches to the struct cpu_spec. The cache flush
> > operation for the specific kind of e500 is selected at init time.
> > The callback function will flush all caches inside the current cpu.
> > 
> > Signed-off-by: Chenhui Zhao <chenhui.zhao@freescale.com>
> > Signed-off-by: Tang Yuantian <Yuantian.Tang@feescale.com>
> > ---
> > v3:
> >       - change all flush_caches to cpu_down_flush
> >       - replace whitespace with tab
> [snip]
>                 .cpu_setup              = __setup_cpu_e500v2,
> >               .machine_check          = machine_check_e500,
> >               .platform               = "ppc8548",
> > +             .cpu_down_flush = cpu_down_flush_e500v2,
> 
> It's still not lined up.  I'm not a fan of the "line up all the ="
> style, as it's a pain to maintain (and can be harder to read if the 
> "="
> is too far to the right), but mixing the two is worse.
> 
> [Yuantian]:
> I need more clear about this.
> The only difference here is that my function puts ONE tab before "=" 
> and ONE white space after "="; 
> but the other functions in this structure use TWO tabs before "=".  
> Is that what you want?

The existing code aligns all the "=" characters (using whatever number 
of tabs before "=" are required to accomplish that).  Yours doesn't.

-Scott


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/