Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933059AbbFJDiD (ORCPT ); Tue, 9 Jun 2015 23:38:03 -0400 Received: from mail-yh0-f44.google.com ([209.85.213.44]:34332 "EHLO mail-yh0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751748AbbFJDhw (ORCPT ); Tue, 9 Jun 2015 23:37:52 -0400 MIME-Version: 1.0 In-Reply-To: <1433841449.16887.58.camel@x220> References: <1433766561-1330-1-git-send-email-pi-cheng.chen@linaro.org> <1433766561-1330-3-git-send-email-pi-cheng.chen@linaro.org> <1433841449.16887.58.camel@x220> Date: Wed, 10 Jun 2015 11:37:52 +0800 Message-ID: Subject: Re: [PATCH 2/2] cpufreq: mediatek: Add MT8173 cpufreq driver From: Pi-Cheng Chen To: Paul Bolle Cc: Viresh Kumar , Mike Turquette , Matthias Brugger , Mark Rutland , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List , "linux-pm@vger.kernel.org" , Linaro Kernel Mailman List , linux-mediatek@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 885 Lines: 37 On Tue, Jun 9, 2015 at 5:17 PM, Paul Bolle wrote: > On Mon, 2015-06-08 at 20:29 +0800, Pi-Cheng Chen wrote: >> --- /dev/null >> +++ b/drivers/cpufreq/mt8173-cpufreq.c > >> +#include > > Weren't you going to drop this include? Sorry I forget to merge that part of fix into this patch. Will fix it. > >> +module_init(mt8173_cpufreq_driver_init); > > For built-in code this is equivalent to, speaking from memory: > device_initcall(mt8173_cpufreq_driver_init); > > Why don't you just use that directly? Yes. Will do it. Thanks for reviewing. Best Regards, Pi-Cheng > > Thanks, > > > Paul Bolle > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/