Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753128AbbFJE6o (ORCPT ); Wed, 10 Jun 2015 00:58:44 -0400 Received: from smtp.nue.novell.com ([195.135.221.5]:54194 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750784AbbFJE6g (ORCPT ); Wed, 10 Jun 2015 00:58:36 -0400 X-Greylist: delayed 1200 seconds by postgrey-1.27 at vger.kernel.org; Wed, 10 Jun 2015 00:58:35 EDT Date: Wed, 10 Jun 2015 12:38:21 +0800 From: joeyli To: "Rafael J. Wysocki" Cc: Toshi Kani , ACPI Devel Maling List , Linux Kernel Mailing List , Len Brown , Marius Tolzmann , Matt Fleming , Aaron Lu , Lv Zheng Subject: Re: [PATCH] ACPI / init: Switch over platform to the ACPI mode later Message-ID: <20150610043821.GC16199@linux-rxt1.site> References: <12578608.kKCTgirQ6f@vostro.rjw.lan> <1433351637.23540.170.camel@misato.fc.hp.com> <13170654.9h99FfQLut@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <13170654.9h99FfQLut@vostro.rjw.lan> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4136 Lines: 90 On Wed, Jun 10, 2015 at 01:48:29AM +0200, Rafael J. Wysocki wrote: > On Wednesday, June 03, 2015 11:13:57 AM Toshi Kani wrote: > > On Sat, 2015-05-30 at 14:21 +0200, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > Commit 73f7d1ca3263 "ACPI / init: Run acpi_early_init() before > > > timekeeping_init()" moved the ACPI subsystem initialization, > > > including the ACPI mode enabling, to an earlier point in the > > > initialization sequence, to allow the timekeeping subsystem > > > use ACPI early. Unfortunately, that resulted in boot regressions > > > on some systems and the early ACPI initialization was moved toward > > > its original position in the kernel initialization code by commit > > > c4e1acbb35e4 "ACPI / init: Invoke early ACPI initialization later". > > > > > > However, that turns out to be insufficient, as boot is still broken > > > on the Tyan S8812 mainboard. > > > > > > To fix that issue, split the ACPI early initialization code into > > > two pieces so the majority of it still located in acpi_early_init() > > > and the part switching over the platform into the ACPI mode goes into > > > a new function, acpi_subsystem_init(), executed at the original early > > > ACPI initialization spot. > > > > > > That fixes the Tyan S8812 boot problem, but still allows ACPI > > > tables to be loaded earlier which is useful to the EFI code in > > > efi_enter_virtual_mode(). > > > > > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=97141 > > > Reported-and-tested-by: Marius Tolzmann > > > Signed-off-by: Rafael J. Wysocki > > > > Can you add comments to acpi_early_init() and acpi_subsystem_init() to > > clarify what ACPI features are enabled at each phase, and what > > dependency they have in the boot sequence? (The same goes to > > early_acpi_boot_init() and acpi_boot_init().) > > OK, update follows. > > --- > From: Rafael J. Wysocki > Subject: ACPI / init: Switch over platform to the ACPI mode later > > Commit 73f7d1ca3263 "ACPI / init: Run acpi_early_init() before > timekeeping_init()" moved the ACPI subsystem initialization, > including the ACPI mode enabling, to an earlier point in the > initialization sequence, to allow the timekeeping subsystem > use ACPI early. Unfortunately, that resulted in boot regressions > on some systems and the early ACPI initialization was moved toward > its original position in the kernel initialization code by commit > c4e1acbb35e4 "ACPI / init: Invoke early ACPI initialization later". > > However, that turns out to be insufficient, as boot is still broken > on the Tyan S8812 mainboard. > > To fix that issue, split the ACPI early initialization code into > two pieces so the majority of it still located in acpi_early_init() > and the part switching over the platform into the ACPI mode goes into > a new function, acpi_subsystem_init(), executed at the original early > ACPI initialization spot. > > That fixes the Tyan S8812 boot problem, but still allows ACPI > tables to be loaded earlier which is useful to the EFI code in > efi_enter_virtual_mode(). > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=97141 > Fixes: 73f7d1ca3263 "ACPI / init: Run acpi_early_init() before timekeeping_init()" > Reported-and-tested-by: Marius Tolzmann > Signed-off-by: Rafael J. Wysocki > Acked-by: Toshi Kani > --- > drivers/acpi/bus.c | 56 +++++++++++++++++++++++++++++++++++++-------------- > include/linux/acpi.h | 2 + > init/main.c | 1 > 3 files changed, 44 insertions(+), 15 deletions(-) About bko#97141, I am still curious why the platform didn't set SCI_EN in that early stage. Thanks for Rafael's patch. Reviewed-by: Lee, Chun-Yi Regards Joey Lee -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/