From: Lisa Du <cldu@marvell.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: A race condition between debugfs and seq_file operation
Thread-Topic: A race condition between debugfs and seq_file operation
Thread-Index: AQHQoaOGA0gdqb5zJkWNmEry1J5dT52lI+0AgAAL0fA=
Date: Wed, 10 Jun 2015 05:00:03 +0000
Message-ID: <9473dc801fb245ea8df91da31d426f7f@SC-EXCH04.marvell.com>
References: <CAG9bXvm70+hE5qsk1UGCzXn3d6FcDs1AJhjM-Homcsu2OmHt6w@mail.gmail.com>
 <CAG9bXv=xFZfuX26OXA+5Go38+JXbq-rwbhcjnyKdTacerRtCvA@mail.gmail.com>
 <CAG9bXvnTPkD8ZDKNakqzKVuJ+iOETdYj6=R2moTnmdUP=X1YVw@mail.gmail.com>
 <3626bdb18cfc40c98618d0ee68816ab0@SC-EXCH04.marvell.com>
 <20150609211202.GA16801@kroah.com>
In-Reply-To: <20150609211202.GA16801@kroah.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
Content-Type: text/plain; charset="gb2312"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1453
Lines: 40

> -----Original Message-----
> From: gregkh@linuxfoundation.org [mailto:gregkh@linuxfoundation.org]
> Sent: 2015??6??10?? 5:12
> To: Lisa Du
> Cc: linux-kernel@vger.kernel.org
> Subject: Re: A race condition between debugfs and seq_file operation
> 
> On Mon, Jun 08, 2015 at 04:28:10AM +0000, Lisa Du wrote:
> > Hi, All
> > Recently I met one race condition related to debugfs.
> >
> > Take an example from ion.c in kernel3.14:
> > static int ion_debug_client_open(struct inode *inode, struct file
> > *file) {
> > 	return single_open(file, ion_debug_client_show, inode->i_private); }
> >
> > static const struct file_operations debug_client_fops = {
> > 	.open = ion_debug_client_open,
> > 	.read = seq_read,
> > 	.llseek = seq_lseek,
> > 	.release = single_release,
> > };
> > client->debug_root = debugfs_create_file(client->display_name, 0664,
> > 					dev->clients_debug_root,
> > 					client, &debug_client_fops);
> >
> > I find during I read the debugfs node, driver can do
> > debugfs_remove_recursive(dentry); Is it expected?
> 
> Yes.  Well, not "expected", but a mess, yes.
> 
> Removing debugfs files are known to have lots of races, this isn't the only
> one :(
Thanks for the reply! 
Not sure if there is any plan to resolve such races in the future?
> 
> thanks,
> 
> greg k-h
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?