Message-ID: <5577D257.4090409@rock-chips.com>
Date: Wed, 10 Jun 2015 13:59:51 +0800
From: Kever Yang <kever.yang@rock-chips.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Caesar Wang <wxt@rock-chips.com>, Heiko Stuebner <heiko@sntech.de>
CC: Russell King <linux@arm.linux.org.uk>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>, dianders@chromium.org,
        linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 3/3] ARM: rockchip: fix the SMP code style
References: <1433843400-24831-1-git-send-email-wxt@rock-chips.com> <1433843400-24831-4-git-send-email-wxt@rock-chips.com>
In-Reply-To: <1433843400-24831-4-git-send-email-wxt@rock-chips.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 3018
Lines: 88

Hi Caesar,

On 06/09/2015 05:49 PM, Caesar Wang wrote:
> Use the below scripts to check:
> scripts/checkpatch.pl -f --subject arch/arm/mach-rockchip/platsmp.c
>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
>
> ---
>
> Changes in v6:
> - fix the commnet Unified format.
> Series-changes: 5
> - Add the changelog.
> Series-changes: 2
> - Use the checkpatch.pl -f --subjective to check.
>
>   arch/arm/mach-rockchip/platsmp.c | 14 ++++++++------
>   1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/mach-rockchip/platsmp.c b/arch/arm/mach-rockchip/platsmp.c
> index d629206..30ccb82 100644
> --- a/arch/arm/mach-rockchip/platsmp.c
> +++ b/arch/arm/mach-rockchip/platsmp.c
> @@ -100,7 +100,7 @@ static int pmu_set_power_domain(int pd, bool on)
>   		ret = pmu_power_domain_is_on(pd);
>   		if (ret < 0) {
>   			pr_err("%s: could not read power domain state\n",
> -				 __func__);
> +			       __func__);
>   			return ret;
>   		}
>   	}
> @@ -130,7 +130,7 @@ static int __cpuinit rockchip_boot_secondary(unsigned int cpu,
>   
>   	if (cpu >= ncores) {
>   		pr_err("%s: cpu %d outside maximum number of cpus %d\n",
> -							__func__, cpu, ncores);
> +		       __func__, cpu, ncores);
>   		return -ENXIO;
>   	}
>   
> @@ -140,7 +140,8 @@ static int __cpuinit rockchip_boot_secondary(unsigned int cpu,
>   		return ret;
>   
>   	if (read_cpuid_part() != ARM_CPU_PART_CORTEX_A9) {
> -		/* We communicate with the bootrom to active the cpus other
> +		/*
> +		 * We communicate with the bootrom to active the cpus other
>   		 * than cpu0, after a blob of initialize code, they will
>   		 * stay at wfe state, once they are actived, they will check
>   		 * the mailbox:
> @@ -149,11 +150,11 @@ static int __cpuinit rockchip_boot_secondary(unsigned int cpu,
>   		 * The cpu0 need to wait the other cpus other than cpu0 entering
>   		 * the wfe state.The wait time is affected by many aspects.
>   		 * (e.g: cpu frequency, bootrom frequency, sram frequency, ...)
> -		 * */
> +		 */
>   		mdelay(1); /* ensure the cpus other than cpu0 to startup */
>   
>   		writel(virt_to_phys(rockchip_secondary_startup),
> -			sram_base_addr + 8);
> +		       sram_base_addr + 8);
>   		writel(0xDEADBEAF, sram_base_addr + 4);
>   		dsb_sev();
>   	}
> @@ -336,7 +337,7 @@ static int rockchip_cpu_kill(unsigned int cpu)
>   static void rockchip_cpu_die(unsigned int cpu)
>   {
>   	v7_exit_coherency_flush(louis);
> -	while(1)
> +	while (1)
>   		cpu_do_idle();
>   }
>   #endif
> @@ -349,4 +350,5 @@ static struct smp_operations rockchip_smp_ops __initdata = {
>   	.cpu_die		= rockchip_cpu_die,
>   #endif
>   };
> +
>   CPU_METHOD_OF_DECLARE(rk3066_smp, "rockchip,rk3066-smp", &rockchip_smp_ops);
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/