From: Jianhua Xie <Jianhua.Xie@freescale.com>
To: Madalin-Cristian Bucur <madalin.bucur@freescale.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [RFC,v3 02/10] dpaa_eth: add support for DPAA Ethernet
Thread-Topic: [RFC,v3 02/10] dpaa_eth: add support for DPAA Ethernet
Thread-Index: AQHQgo1Z41gQqwed9EeFFkAzPBeHHZ2lfPXg
Date: Wed, 10 Jun 2015 06:00:17 +0000
Message-ID: <DM2PR0301MB086380B3D89425345562F384F3BD0@DM2PR0301MB0863.namprd03.prod.outlook.com>
References: <1430319405-31280-1-git-send-email-madalin.bucur@freescale.com>
In-Reply-To: <1430319405-31280-1-git-send-email-madalin.bucur@freescale.com>
Accept-Language: en-US, zh-CN
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2015 06:00:17.6366
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR03MB553
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id t5A60Xn3000731
Content-Length: 1568
Lines: 51


> -----Original Message-----
> From: Linuxppc-dev [mailto:linuxppc-dev-
> bounces+jianhua.xie=freescale.com@lists.ozlabs.org] On Behalf Of Madalin
> Bucur
> Sent: Wednesday, April 29, 2015 10:57 PM
> To: netdev@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> Cc: linux-kernel@vger.kernel.org; Bucur Madalin-Cristian-B32716
> Subject: [RFC,v3 02/10] dpaa_eth: add support for DPAA Ethernet
> 
> This introduces the Freescale Data Path Acceleration Architecture
> (DPAA) Ethernet driver (dpaa_eth) that builds upon the DPAA QMan,
> BMan, PAMU and FMan drivers to deliver Ethernet connectivity on
> the Freescale DPAA QorIQ platforms.
> 
Snip......

> +
> +	if (unlikely(dpa_xmit(priv, percpu_stats, queue_mapping, &fd) < 0))
> +		goto xmit_failed;
> +
> +	net_dev->trans_start = jiffies;

It is probably better to use netdev_queue->trans_start to instead of net_dev->trans_start on SMP.

Best Regards,
Jianhua

> +	return NETDEV_TX_OK;
> +
> +xmit_failed:
> +	if (fd.cmd & FM_FD_CMD_FCO) {
> +		(*countptr)--;
> +		dpa_fd_release(net_dev, &fd);
> +		percpu_stats->tx_errors++;
> +		return NETDEV_TX_OK;
> +	}
> +	_dpa_cleanup_tx_fd(priv, &fd);
> +	percpu_stats->tx_errors++;
> +	dev_kfree_skb(skb);
> +	return NETDEV_TX_OK;
> +}
> --
> 1.7.11.7
> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?