Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933248AbbFJGa3 (ORCPT ); Wed, 10 Jun 2015 02:30:29 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47583 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933145AbbFJGaY (ORCPT ); Wed, 10 Jun 2015 02:30:24 -0400 Date: Wed, 10 Jun 2015 08:30:16 +0200 From: Johannes Thumshirn To: Colin King Cc: Kashyap Desai , Sumit Saxena , Uday Lingala , "James E.J. Bottomley" , megaraidlinux.pdl@avagotech.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] megaraid_sas: insert missing space in kernel message Message-ID: <20150610063016.GA2780@c203.arch.suse.de> References: <1433865223-15310-1-git-send-email-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1433865223-15310-1-git-send-email-colin.king@canonical.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1673 Lines: 42 On Tue, Jun 09, 2015 at 04:53:43PM +0100, Colin King wrote: > From: Colin Ian King > > The printk format specifier string is missing a space between > the %p format specifier and the "on the defer" text. Minor fix, > add the missing space. > > Signed-off-by: Colin Ian King > --- > drivers/scsi/megaraid/megaraid_sas_base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c > index 890637f..4889ef6 100644 > --- a/drivers/scsi/megaraid/megaraid_sas_base.c > +++ b/drivers/scsi/megaraid/megaraid_sas_base.c > @@ -3148,7 +3148,7 @@ megasas_internal_reset_defer_cmds(struct megasas_instance *instance) > cmd = instance->cmd_list[i]; > if (cmd->sync_cmd == 1 || cmd->scmd) { > printk(KERN_NOTICE "megasas: moving cmd[%d]:%p:%d:%p" > - "on the defer queue as internal\n", > + " on the defer queue as internal\n", > defer_index, cmd, cmd->sync_cmd, cmd->scmd); > > if (!list_empty(&cmd->list)) { > -- > 2.1.4 > Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N?rnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/