Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754169AbbFJGo1 (ORCPT ); Wed, 10 Jun 2015 02:44:27 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:62726 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754063AbbFJGoU (ORCPT ); Wed, 10 Jun 2015 02:44:20 -0400 X-IronPort-AV: E=Sophos;i="5.13,586,1427752800"; d="scan'208";a="135431765" Date: Wed, 10 Jun 2015 08:44:17 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Sergey Senozhatsky cc: Julia Lawall , Joe Perches , Andrew Morton , Sergey Senozhatsky , Minchan Kim , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Michal Hocko , David Rientjes , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH 0/5] do not dereference NULL pools in pools' destroy() functions In-Reply-To: <20150610064108.GB566@swordfish> Message-ID: References: <1433851493-23685-1-git-send-email-sergey.senozhatsky@gmail.com> <20150609142523.b717dba6033ee08de997c8be@linux-foundation.org> <1433894769.2730.87.camel@perches.com> <20150610064108.GB566@swordfish> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2311 Lines: 66 On Wed, 10 Jun 2015, Sergey Senozhatsky wrote: > On (06/10/15 07:46), Julia Lawall wrote: > > > > Well I like it, even though it's going to cause a zillion little cleanup > > > > patches. > > > > Actually only at most 87. There are some functions that look quite a bit > > nicer with the change, like: > > > > void jffs2_destroy_slab_caches(void) > > { > > - if(full_dnode_slab) > > - kmem_cache_destroy(full_dnode_slab); > > - if(raw_dirent_slab) > > - kmem_cache_destroy(raw_dirent_slab); > > - if(raw_inode_slab) > > - kmem_cache_destroy(raw_inode_slab); > > - if(tmp_dnode_info_slab) > > - kmem_cache_destroy(tmp_dnode_info_slab); > > - if(raw_node_ref_slab) > > - kmem_cache_destroy(raw_node_ref_slab); > > - if(node_frag_slab) > > - kmem_cache_destroy(node_frag_slab); > > - if(inode_cache_slab) > > - kmem_cache_destroy(inode_cache_slab); > > + kmem_cache_destroy(full_dnode_slab); > > + kmem_cache_destroy(raw_dirent_slab); > > + kmem_cache_destroy(raw_inode_slab); > > + kmem_cache_destroy(tmp_dnode_info_slab); > > + kmem_cache_destroy(raw_node_ref_slab); > > + kmem_cache_destroy(node_frag_slab); > > + kmem_cache_destroy(inode_cache_slab); > > #ifdef CONFIG_JFFS2_FS_XATTR > > - if (xattr_datum_cache) > > - kmem_cache_destroy(xattr_datum_cache); > > - if (xattr_ref_cache) > > - kmem_cache_destroy(xattr_ref_cache); > > + kmem_cache_destroy(xattr_datum_cache); > > + kmem_cache_destroy(xattr_ref_cache); > > #endif > > } > > > > and some goto labels can go away either. like > > [..] > > err_percpu_counter_init: > kmem_cache_destroy(sctp_chunk_cachep); > err_chunk_cachep: > kmem_cache_destroy(sctp_bucket_cachep); > > [..] > > and others. This I find much less appealing. The labels make clear what is needed at what point. At least from a tool point of view, this is useful infomation. julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/