From: Romain Francoise <romain@orebokech.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Tahsin Erdogan <tahsin@google.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: Make CFQ default to IOPS mode on SSDs
Organization: orebokech dot com
References: <1432068921-17184-1-git-send-email-tahsin@google.com>
	<873821kww7.fsf@orebokech.com> <55772585.30707@kernel.dk>
Date: Wed, 10 Jun 2015 08:44:56 +0200
In-Reply-To: <55772585.30707@kernel.dk> (Jens Axboe's message of "Tue, 09 Jun
	2015 11:42:29 -0600")
Message-ID: <87y4jsjc47.fsf@orebokech.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 797
Lines: 20

Hi,

On Tue, Jun 09, 2015 at 11:42:29AM -0600, Jens Axboe wrote:
> There are a few options to handle this. The attached might work, not
> tested at all. Basically it adds an io sched registration hook, that is
> called when we are adding the disk on the queue. Non-rotational
> detection should be done at that point.
>
> Does that work for you?

Yep, that works perfectly in my (admittedly limited) testing; slice_idle
is correctly set to 0 on non-rotational devices and keeps its default
value of 8 otherwise. Feel free to add my Tested-by.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/