Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964814AbbFJHIU (ORCPT ); Wed, 10 Jun 2015 03:08:20 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:36717 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751431AbbFJHIN (ORCPT ); Wed, 10 Jun 2015 03:08:13 -0400 Date: Wed, 10 Jun 2015 12:38:05 +0530 From: Sudip Mukherjee To: green@linuxhacker.ru Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , Linux Kernel Mailing List Subject: Re: [PATCH 1/2] staging/lustre/llite: remove LL_IOC_REMOVE_ENTRY handler Message-ID: <20150610070805.GC7035@sudip-PC> References: <1433911283-24902-1-git-send-email-green@linuxhacker.ru> <1433911283-24902-2-git-send-email-green@linuxhacker.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433911283-24902-2-git-send-email-green@linuxhacker.ru> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 761 Lines: 18 On Wed, Jun 10, 2015 at 12:41:22AM -0400, green@linuxhacker.ru wrote: > From: Oleg Drokin > > It uses getname in unsafe manner and since it's to deal with corrupted > or inconsistent filesystem, we are probably better to deal with > it from lfsck anyway. I am not sure but will it not break the userspace? There may be some application who is using this ioctl. And I think you missed removing the #define LL_IOC_REMOVE_ENTRY from lustre_user.h which will not be used anymore. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/