Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933499AbbFJHMZ (ORCPT ); Wed, 10 Jun 2015 03:12:25 -0400 Received: from mail-la0-f45.google.com ([209.85.215.45]:32875 "EHLO mail-la0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933472AbbFJHMH (ORCPT ); Wed, 10 Jun 2015 03:12:07 -0400 MIME-Version: 1.0 In-Reply-To: References: <1433686811-12303-1-git-send-email-grant.likely@linaro.org> <1433686811-12303-3-git-send-email-grant.likely@linaro.org> <20150608184713.446B7C406AA@trevor.secretlab.ca> <20150609110044.61031C40580@trevor.secretlab.ca> From: Ricardo Ribalda Delgado Date: Wed, 10 Jun 2015 09:11:45 +0200 Message-ID: Subject: Re: [PATCH 2/2] drivercore: Fix unregistration path of platform devices To: Kevin Hilman Cc: Grant Likely , Rob Herring , Bjorn Helgaas , "devicetree@vger.kernel.org" , LKML , Pantelis Antoniou , Wolfram Sang , Rob Herring , Greg Kroah-Hartman , Tyler Baker , Olof Johansson Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2262 Lines: 68 Hi Kevin, Hi Grant, Hi Greg Although I do not agree with everything exposed by Grant, I understand his concerns as a Maintainer with future support of the code. Also there is no point in wasting more energy in discussing than in coding. So, in order to make everybody life a bit easier I think a good plan here is: 1) revert the whole serie :( 2) apply Grant patch (you can add my Acked-by) and propose his inclusion for back-porting in 4.0 3) I post a patch series with the cleanout missing in his patch. Not needed to be backported, but nice it is merged soon, since it has been already reviewed by Bjorn and Rob. 4) I post a patch series with the resource flag and "Use platform_device interface". And we can disscuss if this is good sollution or not Could be nice to be able to test the code on 4) on the "broken platforms". Do we all agree on this plan? Thanks and Kevin sorry for wasting your time. On Wed, Jun 10, 2015 at 2:22 AM, Kevin Hilman wrote: > On Tue, Jun 9, 2015 at 4:00 AM, Grant Likely wrote: >> On Mon, 8 Jun 2015 22:09:13 +0200 >> , Ricardo Ribalda Delgado wrote: > > [...] > >>> >>> > Greg, please drop Ricardo's series. It isn't correct and it will cause >>> > breakage. >>> >>> The series can be kept, only >>> >>> patch "of/platform: Use platform_device interface" >>> >>> needs to be reverted. >> >> No, it's better to drop the whole series. There are still issues and it >> will conflict with merging the bugfix for v4.1. >> > > Multiple platforms stopped booting in next-20150609 as discovered by > kernelci.org[1], and was bisected down to commit b6d2233f2916 > (of/platform: Use platform_device interface). > > I'll leave you guys to sort out whether that patch or the whole series > should be reverted, but I can confirm that reverting that patch on top > of next-20150609 gets things booting again. > > Kevin > > [1] http://kernelci.org/boot/all/job/next/kernel/next-20150609/ -- Ricardo Ribalda -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/