From: Madalin-Cristian Bucur <madalin.bucur@freescale.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jianhua Xie <Jianhua.Xie@freescale.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: RE: [RFC,v3 02/10] dpaa_eth: add support for DPAA Ethernet
Thread-Topic: [RFC,v3 02/10] dpaa_eth: add support for DPAA Ethernet
Thread-Index: AQHQgoy67USkhZ9S4U2K7B2IZnjQHp2lgFmAgAAZ6PA=
Date: Wed, 10 Jun 2015 07:38:06 +0000
Message-ID: <BL2PR03MB545CA85B1FE886FCD07DE26E6BD0@BL2PR03MB545.namprd03.prod.outlook.com>
References: <1430319405-31280-1-git-send-email-madalin.bucur@freescale.com>
 <DM2PR0301MB086380B3D89425345562F384F3BD0@DM2PR0301MB0863.namprd03.prod.outlook.com>
In-Reply-To: <DM2PR0301MB086380B3D89425345562F384F3BD0@DM2PR0301MB0863.namprd03.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2015 07:38:06.9479
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB0861
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id t5A9AWUB001908
Content-Length: 2337
Lines: 71

Hi Eric,

Can you please tell us if this change would be for the better?

I was about to say yes to this request but checked and no other Ethernet driver seems to use the queue trans_start.
I was able to find your patch "net: tx scalability works : trans_start" [ http://patchwork.ozlabs.org/patch/27104/ ] but did not find more about this topic.
 
Thank you,
Madalin

> -----Original Message-----
> From: Xie Jianhua-B29408
> Sent: Wednesday, June 10, 2015 9:00 AM
> To: Bucur Madalin-Cristian-B32716; netdev@vger.kernel.org; linuxppc-
> dev@lists.ozlabs.org
> Cc: linux-kernel@vger.kernel.org
> Subject: RE: [RFC,v3 02/10] dpaa_eth: add support for DPAA Ethernet
> 
> 
> 
> > -----Original Message-----
> > From: Linuxppc-dev [mailto:linuxppc-dev-
> > bounces+jianhua.xie=freescale.com@lists.ozlabs.org] On Behalf Of
> Madalin
> > Bucur
> > Sent: Wednesday, April 29, 2015 10:57 PM
> > To: netdev@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > Cc: linux-kernel@vger.kernel.org; Bucur Madalin-Cristian-B32716
> > Subject: [RFC,v3 02/10] dpaa_eth: add support for DPAA Ethernet
> >
> > This introduces the Freescale Data Path Acceleration Architecture
> > (DPAA) Ethernet driver (dpaa_eth) that builds upon the DPAA QMan,
> > BMan, PAMU and FMan drivers to deliver Ethernet connectivity on
> > the Freescale DPAA QorIQ platforms.
> >
> Snip......
> 
> > +
> > +	if (unlikely(dpa_xmit(priv, percpu_stats, queue_mapping, &fd) < 0))
> > +		goto xmit_failed;
> > +
> > +	net_dev->trans_start = jiffies;
> 
> It is probably better to use netdev_queue->trans_start to instead of
> net_dev->trans_start on SMP.
> 
> Best Regards,
> Jianhua
> 
> > +	return NETDEV_TX_OK;
> > +
> > +xmit_failed:
> > +	if (fd.cmd & FM_FD_CMD_FCO) {
> > +		(*countptr)--;
> > +		dpa_fd_release(net_dev, &fd);
> > +		percpu_stats->tx_errors++;
> > +		return NETDEV_TX_OK;
> > +	}
> > +	_dpa_cleanup_tx_fd(priv, &fd);
> > +	percpu_stats->tx_errors++;
> > +	dev_kfree_skb(skb);
> > +	return NETDEV_TX_OK;
> > +}
> > --
> > 1.7.11.7
> >
> > _______________________________________________
> > Linuxppc-dev mailing list
> > Linuxppc-dev@lists.ozlabs.org
> > https://lists.ozlabs.org/listinfo/linuxppc-dev
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?