Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964845AbbFJIFk (ORCPT ); Wed, 10 Jun 2015 04:05:40 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:29791 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933224AbbFJIF0 (ORCPT ); Wed, 10 Jun 2015 04:05:26 -0400 Date: Wed, 10 Jun 2015 10:05:53 +0200 From: Ludovic Desroches To: Sergei Shtylyov CC: Cyrille Pitchen , , , , , , , , , , , , Subject: Re: [PATCH v6 5/6] i2c: at91: print hardware version Message-ID: <20150610080553.GO25800@odux.rfo.atmel.com> Mail-Followup-To: Sergei Shtylyov , Cyrille Pitchen , nicolas.ferre@atmel.com, linux-i2c@vger.kernel.org, wsa@the-dreams.de, mark.rutland@arm.com, devicetree@vger.kernel.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org, robh+dt@kernel.org, galak@codeaurora.org, linux-arm-kernel@lists.infradead.org References: <5577428C.3090206@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <5577428C.3090206@cogentembedded.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1331 Lines: 46 On Tue, Jun 09, 2015 at 10:46:20PM +0300, Sergei Shtylyov wrote: > Hello. > > On 06/09/2015 07:22 PM, Cyrille Pitchen wrote: > > >The probe() function now prints the hardware version of the I2C > >controller. > > >Signed-off-by: Cyrille Pitchen > >--- > > drivers/i2c/busses/i2c-at91.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > >diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c > >index 817ae69..6e88b30 100644 > >--- a/drivers/i2c/busses/i2c-at91.c > >+++ b/drivers/i2c/busses/i2c-at91.c > [...] > >@@ -908,7 +910,8 @@ static int at91_twi_probe(struct platform_device *pdev) > > return rc; > > } > > > >- dev_info(dev->dev, "AT91 i2c bus driver.\n"); > >+ dev_info(dev->dev, "AT91 i2c bus driver (version: %#x).\n", > > It looks as if you rather print the driver's version. :-) >From my point of view, having a version number for a Linux driver would be strange so it's not confusing. > > >+ at91_twi_read(dev, AT91_TWI_VER)); > > return 0; > > } > > WBR, Sergei > Regards Ludovic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/