Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965522AbbFJOPF (ORCPT ); Wed, 10 Jun 2015 10:15:05 -0400 Received: from mailuogwhop.emc.com ([168.159.213.141]:43197 "EHLO mailuogwhop.emc.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964921AbbFJOJH (ORCPT ); Wed, 10 Jun 2015 10:09:07 -0400 X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd02.lss.emc.com t5AE91iF015645 X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd02.lss.emc.com t5AE91iF015645 From: Allen Hubbe To: linux-ntb@googlegroups.com Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Jon Mason , Dave Jiang , Allen Hubbe Subject: [PATCH v4 08/19] NTB: Do not advance transport RX on link down Date: Wed, 10 Jun 2015 05:08:13 -0400 Message-Id: <9bd941c6bdf4e540f44b02bb0b0eeb1d031bedf5.1433925092.git.Allen.Hubbe@emc.com> X-Mailer: git-send-email 2.4.0.rc0.44.g244209c.dirty In-Reply-To: References: In-Reply-To: References: X-RSA-Classifications: public X-Sentrion-Hostname: mailuogwprd02.lss.emc.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1026 Lines: 30 On link down, don't advance RX index to the next entry. The next entry should never be valid after receiving the link down flag. Signed-off-by: Allen Hubbe --- drivers/ntb/ntb_transport.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c index 8d9b59f7fa07..0f86b60a0c0e 100644 --- a/drivers/ntb/ntb_transport.c +++ b/drivers/ntb/ntb_transport.c @@ -1212,8 +1212,7 @@ static int ntb_process_rxc(struct ntb_transport_qp *qp) dev_dbg(&qp->ndev->pdev->dev, "link down flag set\n"); ntb_qp_link_down(qp); hdr->flags = 0; - iowrite32(qp->rx_index, &qp->rx_info->entry); - return 0; + return -EAGAIN; } if (hdr->ver != (u32)qp->rx_pkts) { -- 2.4.0.rc0.43.gcf8a8c6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/