Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933533AbbFJJKi (ORCPT ); Wed, 10 Jun 2015 05:10:38 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:34031 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933475AbbFJJKc (ORCPT ); Wed, 10 Jun 2015 05:10:32 -0400 Date: Wed, 10 Jun 2015 10:10:27 +0100 From: Lee Jones To: Lothar =?iso-8859-1?Q?Wa=DFmann?= Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, broonie@kernel.org, kernel@stlinux.com, lgirdwood@gmail.com Subject: Re: [REBASED 2/5] regulator: pwm-regulator: Separate voltage-table initialisation Message-ID: <20150610091027.GB2982@x1> References: <1433923073-907-1-git-send-email-lee.jones@linaro.org> <1433923073-907-3-git-send-email-lee.jones@linaro.org> <20150610110206.6194cc0f@ipc1.ka-ro> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150610110206.6194cc0f@ipc1.ka-ro> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1956 Lines: 58 Oh my ... On Wed, 10 Jun 2015, Lothar Waßmann wrote: > > Take this out of the main .probe() routine in order to facilitate the > > introduction of different ways to obtain 'duty cycle' information. > > > > Signed-off-by: Lee Jones > > --- > > drivers/mfd/mfd-child.c | 47 ++++++++++++++++++++++++ > > drivers/regulator/pwm-regulator.c | 77 +++++++++++++++++++++++---------------- > > 2 files changed, 92 insertions(+), 32 deletions(-) > > create mode 100644 drivers/mfd/mfd-child.c > > > > diff --git a/drivers/mfd/mfd-child.c b/drivers/mfd/mfd-child.c > > new file mode 100644 > > index 0000000..f233add > > --- /dev/null > > +++ b/drivers/mfd/mfd-child.c > > @@ -0,0 +1,47 @@ > > +#include > > +#include > > +#include > > +#include > > + > > +static int simple_mfd_child_probe(struct platform_device *pdev) > > +{ > > + struct resource *res; > > + void __iomem *base; > > + int irq; > > + > > + printk("LEE: %s %s()[%d]: Enter\n", __FILE__, __func__, __LINE__); > > + > Debugging remnant? > > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + dev_err(&pdev->dev, "Phys: %x: %x\n", res->start, resource_size(res)); > > + > That's not an error message and thus shouldn't be printed with > dev_err(). dev_dbg() would be more appropriate here. This entire file is cruft and has nothing to do with this set. It was knocked it up quickly to test something unrelated. I will resubmit this patch with it removed. Sorry for the noise. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/