Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753972AbbFJKSI (ORCPT ); Wed, 10 Jun 2015 06:18:08 -0400 Received: from mail-wg0-f45.google.com ([74.125.82.45]:33218 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752385AbbFJKR7 convert rfc822-to-8bit (ORCPT ); Wed, 10 Jun 2015 06:17:59 -0400 Date: Wed, 10 Jun 2015 13:17:55 +0300 From: Mihai =?UTF-8?B?RG9uyJt1?= To: Takashi Iwai Cc: Jonathan McDowell , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: Audio crackles with 4.1-rc1 Message-ID: <20150610131755.0b906783@mdontu-l.dsd.bitdefender.biz> In-Reply-To: References: <20150429112859.GY10148@earth.li> <20150430150131.GA10148@earth.li> <20150502150513.GF10148@earth.li> <20150519161911.GD28070@earth.li> <20150519215310.GF28070@earth.li> Organization: Home MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2382 Lines: 55 On Wed, 20 May 2015 07:01:12 +0200 Takashi Iwai wrote: > From: Takashi Iwai > Subject: [PATCH] ALSA: hda - Disable widget power-saving for ALC292 & co > > We've got reports that ALC3226 (a Dell variant of ALC292) gives click > noises at transition from D3 to D0 when the widget power-saving is > enabled. Further debugging session showed that avoiding it isn't > trivial, unfortunately, since paths are basically activated > dynamically while the pins have been already enabled. > > This patch disables the widget power-saving for such codecs. > > Reported-by: Jonathan McDowell > Signed-off-by: Takashi Iwai > --- > sound/pci/hda/patch_realtek.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 2e246fe495f6..31f8f13be907 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -5623,7 +5623,8 @@ static int patch_alc269(struct hda_codec *codec) > > spec = codec->spec; > spec->gen.shared_mic_vref_pin = 0x18; > - codec->power_save_node = 1; > + if (codec->core.vendor_id != 0x10ec0292) > + codec->power_save_node = 1; > > snd_hda_pick_fixup(codec, alc269_fixup_models, > alc269_fixup_tbl, alc269_fixups); I'm on 4.1-rc7 which appears to contain this patch, however, I still get the audio artifacts (crackles) when I boot my laptop (Latitude E7440): [ 1.058839] snd_hda_codec_realtek hdaudioC1D0: autoconfig for ALC3226: line_outs=1 (0x16/0x0/0x0/0x0/0x0) type:line [ 1.058843] snd_hda_codec_realtek hdaudioC1D0: speaker_outs=1 (0x14/0x0/0x0/0x0/0x0) [ 1.058846] snd_hda_codec_realtek hdaudioC1D0: hp_outs=1 (0x15/0x0/0x0/0x0/0x0) [ 1.058849] snd_hda_codec_realtek hdaudioC1D0: mono: mono_out=0x0 [ 1.058851] snd_hda_codec_realtek hdaudioC1D0: inputs: [ 1.058855] snd_hda_codec_realtek hdaudioC1D0: Dock Mic=0x19 [ 1.058859] snd_hda_codec_realtek hdaudioC1D0: Headset Mic=0x1a [ 1.058862] snd_hda_codec_realtek hdaudioC1D0: Internal Mic=0x12 4.0.4 was fine. -- Mihai Donțu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/