Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933542AbbFJKli (ORCPT ); Wed, 10 Jun 2015 06:41:38 -0400 Received: from mail-la0-f49.google.com ([209.85.215.49]:33236 "EHLO mail-la0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753897AbbFJKlV (ORCPT ); Wed, 10 Jun 2015 06:41:21 -0400 MIME-Version: 1.0 In-Reply-To: References: <1433848247-3550-1-git-send-email-kuleshovmail@gmail.com> <1433848301-5296-1-git-send-email-kuleshovmail@gmail.com> <1433869251.26331.114.camel@linux.intel.com> <1433929488.26331.117.camel@linux.intel.com> Date: Wed, 10 Jun 2015 16:41:19 +0600 Message-ID: Subject: Re: [PATCH v11 4/5] x86/earlyprintk: setup earlyprintk as early as possible From: Alexander Kuleshov To: Andy Shevchenko Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , LKML , Greg Kroah-Hartman , Borislav Petkov , Mark Rustad , Yinghai Lu Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 818 Lines: 19 2015-06-10 16:36 GMT+06:00 Alexander Kuleshov : > 2015-06-10 15:44 GMT+06:00 Andy Shevchenko : >> You do parsing twice (still original code and your piece here), and >> honestly I don't like your approach in this form. > > I just researched earlyprintk and we can use not only serial, but > vga and pciserial. What if I'll rename setup_early_serial_console > to the setup_earlyprintk_console, will add variable, something like > this > We can't use pciserial, accidently hit from cut&paste, sorry for the noise. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/