Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754233AbbFJMPl (ORCPT ); Wed, 10 Jun 2015 08:15:41 -0400 Received: from sauhun.de ([89.238.76.85]:48787 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751398AbbFJMPd (ORCPT ); Wed, 10 Jun 2015 08:15:33 -0400 Date: Wed, 10 Jun 2015 21:15:20 +0900 From: Wolfram Sang To: Sergei Shtylyov Cc: Cyrille Pitchen , nicolas.ferre@atmel.com, linux-i2c@vger.kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org, robh+dt@kernel.org, galak@codeaurora.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 5/6] i2c: at91: print hardware version Message-ID: <20150610121519.GB1592@katana> References: <5577428C.3090206@cogentembedded.com> <20150610080553.GO25800@odux.rfo.atmel.com> <55782935.30608@cogentembedded.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="z6Eq5LdranGa6ru8" Content-Disposition: inline In-Reply-To: <55782935.30608@cogentembedded.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1778 Lines: 48 --z6Eq5LdranGa6ru8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > >>>- dev_info(dev->dev, "AT91 i2c bus driver.\n"); > >>>+ dev_info(dev->dev, "AT91 i2c bus driver (version: %#x).\n", >=20 > >> It looks as if you rather print the driver's version. :-) >=20 > > From my point of view, having a version number for a Linux driver would > >be strange >=20 > Not everybody shares your opinion. I tend to agree with Sergei but let's keep things simple: I'll make it "hw version" before applying. --z6Eq5LdranGa6ru8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVeCpXAAoJEBQN5MwUoCm2akUP/2pFV/nPqlCYBhEkJpbm0pu/ kppaAg8UXYFoW3zAmw5JnDZYU6H3W0gmhOziEZ7KJEOtXvAGInEdosZsGAyfjNhv hROqnIHTJfnA8I/jAFq8ji5/687XhbNYLneMDd+yaUNnYR4Jn3/4matbSH/RXfkE 7X7g/VnMSAgem9cQmGxuz2PMFGzzfwF5bEWNb4kMi4Ov3PzT9sZX7oiYz8mgAySv U/hJUDx05MPJL+zOT6sWXOOlA/mUWHYWGjLFvbYuzNRI4Qr9eQU06D19ruwXkrEK rb4WyvLqAHCa/5fUzsmmG0Rr08bGh3rWsesgFvCONLZQH6RjT54gSGXymtMKrI3y 9Y58w10Z2B2/OS8P8hgGdLgHylA1amDaxLBP3K+VoiuL9Spug8WMkxioeaGPhwH6 kiR7L04oEymR+1//tCd13AWcmA/uLpXpR9oErt1I2CrhEYK4IJN0Yg86pjFOf0s7 +dxh1+2r/O3TzEC9CzLcxou3EfmB8RiSaO75k8YnRkTayy8pGLsjISEbWxbgJZVm 7DAw0toV2cEXCoHMCLzSvMXs5sseHplUK+26NC9g1sBUPzpF11GuGjIbA2l0Oe+t eBeICBfKRWlGExQw82/yaQGtvQ2IF147NZmGYAjRpHJaIGq2xieox8rFo6I/tUYP cKv8Ongu0dtHj3Lflrxk =waUi -----END PGP SIGNATURE----- --z6Eq5LdranGa6ru8-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/