Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932406AbbFJMmM (ORCPT ); Wed, 10 Jun 2015 08:42:12 -0400 Received: from mail-oi0-f54.google.com ([209.85.218.54]:34910 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754001AbbFJMmC (ORCPT ); Wed, 10 Jun 2015 08:42:02 -0400 MIME-Version: 1.0 In-Reply-To: <1433874401-27161-12-git-send-email-robh@kernel.org> References: <1433874401-27161-1-git-send-email-robh@kernel.org> <1433874401-27161-12-git-send-email-robh@kernel.org> Date: Wed, 10 Jun 2015 14:42:01 +0200 Message-ID: Subject: Re: [PATCH 11/15] pinctrl: kill off set_irq_flags usage From: Linus Walleij To: Rob Herring Cc: Russell King , "linux-arm-kernel@lists.infradead.org" , Krzysztof Kozlowski , linux-samsung-soc , Stephen Warren , Lee Jones , "linux-kernel@vger.kernel.org" , Tomasz Figa , "linux-gpio@vger.kernel.org" , "arm@kernel.org" , Thomas Abraham , Kukjin Kim , Matthias Brugger , linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1703 Lines: 41 On Tue, Jun 9, 2015 at 8:26 PM, Rob Herring wrote: > set_irq_flags is ARM specific with custom flags which have genirq > equivalents. Convert drivers to use the genirq interfaces directly, so we > can kill off set_irq_flags. The translation of flags is as follows: > > IRQF_VALID -> !IRQ_NOREQUEST > IRQF_PROBE -> !IRQ_NOPROBE > IRQF_NOAUTOEN -> IRQ_NOAUTOEN > > For IRQs managed by an irqdomain, the irqdomain core code handles clearing > and setting IRQ_NOREQUEST already, so there is no need to do this in > .map() functions and we can simply remove the set_irq_flags calls. Some > users also set IRQ_NOPROBE and this has been maintained although it is not > clear that is really needed. There appears to be a great deal of blind > copy and paste of this code. > > Signed-off-by: Rob Herring > Cc: Linus Walleij > Cc: Stephen Warren > Cc: Lee Jones > Cc: Matthias Brugger > Cc: Tomasz Figa > Cc: Thomas Abraham > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: linux-gpio@vger.kernel.org > Cc: linux-rpi-kernel@lists.infradead.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/