Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964974AbbFJNq0 (ORCPT ); Wed, 10 Jun 2015 09:46:26 -0400 Received: from mail-lb0-f170.google.com ([209.85.217.170]:33752 "EHLO mail-lb0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933623AbbFJNqU (ORCPT ); Wed, 10 Jun 2015 09:46:20 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Wed, 10 Jun 2015 15:46:18 +0200 Message-ID: Subject: Re: [PATCH v2 02/10] kdbus: use parentheses uniformly in KDBUS_ITEMS_FOREACH macro From: David Herrmann To: Sergei Zviagintsev Cc: Greg Kroah-Hartman , Daniel Mack , David Herrmann , Djalal Harouni , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1501 Lines: 41 Hi On Tue, Jun 9, 2015 at 11:00 PM, Sergei Zviagintsev wrote: > Enclose all arguments into parentheses to stay consistent across the > whole macro. > > Signed-off-by: Sergei Zviagintsev > --- > ipc/kdbus/item.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: David Herrmann Thanks David > diff --git a/ipc/kdbus/item.h b/ipc/kdbus/item.h > index 32909e2e7954..bca63b4e6e80 100644 > --- a/ipc/kdbus/item.h > +++ b/ipc/kdbus/item.h > @@ -28,10 +28,10 @@ > #define KDBUS_ITEM_PAYLOAD_SIZE(_i) ((_i)->size - KDBUS_ITEM_HEADER_SIZE) > > #define KDBUS_ITEMS_FOREACH(_i, _is, _s) \ > - for (_i = _is; \ > + for ((_i) = (_is); \ > ((u8 *)(_i) < (u8 *)(_is) + (_s)) && \ > ((u8 *)(_i) >= (u8 *)(_is)); \ > - _i = KDBUS_ITEM_NEXT(_i)) > + (_i) = KDBUS_ITEM_NEXT(_i)) > > #define KDBUS_ITEM_VALID(_i, _is, _s) \ > ((_i)->size >= KDBUS_ITEM_HEADER_SIZE && \ > -- > 1.8.3.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/