Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S964955AbbFJOEB (ORCPT <rfc822;w@1wt.eu>);
	Wed, 10 Jun 2015 10:04:01 -0400
Received: from mail-lb0-f178.google.com ([209.85.217.178]:33500 "EHLO
	mail-lb0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S964910AbbFJODx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 10 Jun 2015 10:03:53 -0400
MIME-Version: 1.0
In-Reply-To: <4330e76b962d4b991d2bf215d33868194388e7e2.1433882692.git.sergei@s15v.net>
References: <cover.1433882692.git.sergei@s15v.net>
	<4330e76b962d4b991d2bf215d33868194388e7e2.1433882692.git.sergei@s15v.net>
Date: Wed, 10 Jun 2015 16:03:52 +0200
Message-ID: <CANq1E4Sf9pOavqO_qJwfWGgVtX_jk24j7FUjPebvndMAR9EoVg@mail.gmail.com>
Subject: Re: [PATCH v2 04/10] Documentation/kdbus: use parentheses uniformly
 in KDBUS_ITEM_FOREACH macro
From: David Herrmann <dh.herrmann@gmail.com>
To: Sergei Zviagintsev <sergei@s15v.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Daniel Mack <daniel@zonque.org>,
        David Herrmann <dh.herrmann@googlemail.com>,
        Djalal Harouni <tixxdz@opendz.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1478
Lines: 41

Hi

On Tue, Jun 9, 2015 at 11:00 PM, Sergei Zviagintsev <sergei@s15v.net> wrote:
> Enclose all arguments into parentheses to stay consistent across the
> whole macro.
>
> Signed-off-by: Sergei Zviagintsev <sergei@s15v.net>
> ---
>  Documentation/kdbus/kdbus.item.xml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/kdbus/kdbus.item.xml b/Documentation/kdbus/kdbus.item.xml
> index b0eeeef995af..ee09dfa443b8 100644
> --- a/Documentation/kdbus/kdbus.item.xml
> +++ b/Documentation/kdbus/kdbus.item.xml
> @@ -72,10 +72,10 @@
>      (typeof(item))((uint8_t *)(item) + KDBUS_ALIGN8((item)->size))

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>

Thanks
David

>  #define KDBUS_ITEM_FOREACH(item, head, first)                      \
> -    for (item = (head)->first;                                     \
> +    for ((item) = (head)->first;                                   \
>           ((uint8_t *)(item) < (uint8_t *)(head) + (head)->size) && \
>            ((uint8_t *)(item) >= (uint8_t *)(head));                \
> -         item = KDBUS_ITEM_NEXT(item))
> +         (item) = KDBUS_ITEM_NEXT(item))
>        ]]></programlisting>
>      </refsect2>
>    </refsect1>
> --
> 1.8.3.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/