Message-ID: <557843CB.6070004@kernel.dk>
Date: Wed, 10 Jun 2015 08:03:55 -0600
From: Jens Axboe <axboe@kernel.dk>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Romain Francoise <romain@orebokech.com>
CC: Tahsin Erdogan <tahsin@google.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: Make CFQ default to IOPS mode on SSDs
References: <1432068921-17184-1-git-send-email-tahsin@google.com>	<873821kww7.fsf@orebokech.com> <55772585.30707@kernel.dk> <87y4jsjc47.fsf@orebokech.com>
In-Reply-To: <87y4jsjc47.fsf@orebokech.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 925
Lines: 27

On 06/10/2015 12:44 AM, Romain Francoise wrote:
> Hi,
>
> On Tue, Jun 09, 2015 at 11:42:29AM -0600, Jens Axboe wrote:
>> There are a few options to handle this. The attached might work, not
>> tested at all. Basically it adds an io sched registration hook, that is
>> called when we are adding the disk on the queue. Non-rotational
>> detection should be done at that point.
>>
>> Does that work for you?
>
> Yep, that works perfectly in my (admittedly limited) testing; slice_idle
> is correctly set to 0 on non-rotational devices and keeps its default
> value of 8 otherwise. Feel free to add my Tested-by.
>
> Thanks!

Thanks for testing, it is now committed.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/