Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965187AbbFJOHF (ORCPT ); Wed, 10 Jun 2015 10:07:05 -0400 Received: from mail-la0-f44.google.com ([209.85.215.44]:36390 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965153AbbFJOGw (ORCPT ); Wed, 10 Jun 2015 10:06:52 -0400 MIME-Version: 1.0 In-Reply-To: <07f27eaed362e9baf92307d3a22198f80fcae197.1433882692.git.sergei@s15v.net> References: <07f27eaed362e9baf92307d3a22198f80fcae197.1433882692.git.sergei@s15v.net> Date: Wed, 10 Jun 2015 16:06:50 +0200 Message-ID: Subject: Re: [PATCH v2 06/10] selftests/kdbus: fix precedence issues in macros From: David Herrmann To: Sergei Zviagintsev Cc: Greg Kroah-Hartman , Daniel Mack , David Herrmann , Djalal Harouni , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3083 Lines: 63 Hi On Tue, Jun 9, 2015 at 11:00 PM, Sergei Zviagintsev wrote: > `item' argument in KDBUS_ITEM_NEXT macro is not enclosed into > parentheses when the cast operator is applied, which leads to improper > type conversion if `item' is supplied as a complex expression, e.g. > > KDBUS_ITEM_NEXT(condition ? a : b) > > RUN_CLONE_CHILD macro has similar issue, missing parentheses around > `clone_ret' when using indirection operator. > > Use parentheses properly to guarantee right precedence. > > Signed-off-by: Sergei Zviagintsev > --- > tools/testing/selftests/kdbus/kdbus-util.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: David Herrmann Thanks David > diff --git a/tools/testing/selftests/kdbus/kdbus-util.h b/tools/testing/selftests/kdbus/kdbus-util.h > index b53b03f0565c..df5721ee8f54 100644 > --- a/tools/testing/selftests/kdbus/kdbus-util.h > +++ b/tools/testing/selftests/kdbus/kdbus-util.h > @@ -27,7 +27,7 @@ > #define KDBUS_ITEM_SIZE(s) KDBUS_ALIGN8((s) + KDBUS_ITEM_HEADER_SIZE) > > #define KDBUS_ITEM_NEXT(item) \ > - (typeof(item))(((uint8_t *)item) + KDBUS_ALIGN8((item)->size)) > + (typeof(item))((uint8_t *)(item) + KDBUS_ALIGN8((item)->size)) > #define KDBUS_ITEM_FOREACH(item, head, first) \ > for (item = (head)->first; \ > ((uint8_t *)(item) < (uint8_t *)(head) + (head)->size) && \ > @@ -104,7 +104,7 @@ extern int kdbus_util_verbose; > _setup_; \ > efd = eventfd(0, EFD_CLOEXEC); \ > ASSERT_RETURN(efd >= 0); \ > - *clone_ret = 0; \ > + *(clone_ret) = 0; \ > pid = syscall(__NR_clone, flags, NULL); \ > if (pid == 0) { \ > eventfd_t event_status = 0; \ > @@ -129,7 +129,7 @@ extern int kdbus_util_verbose; > ret = TEST_OK; \ > } else { \ > ret = -errno; \ > - *clone_ret = -errno; \ > + *(clone_ret) = -errno; \ > } \ > close(efd); \ > ret; \ > -- > 1.8.3.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/