Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964903AbbFJOIc (ORCPT ); Wed, 10 Jun 2015 10:08:32 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:36749 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964909AbbFJOIY (ORCPT ); Wed, 10 Jun 2015 10:08:24 -0400 MIME-Version: 1.0 In-Reply-To: <3b73138edaa447b1ff521247ff4e62eb7e437ece.1433882692.git.sergei@s15v.net> References: <3b73138edaa447b1ff521247ff4e62eb7e437ece.1433882692.git.sergei@s15v.net> Date: Wed, 10 Jun 2015 16:08:22 +0200 Message-ID: Subject: Re: [PATCH v2 07/10] selftests/kdbus: use parentheses in iteration macros uniformly From: David Herrmann To: Sergei Zviagintsev Cc: Greg Kroah-Hartman , Daniel Mack , David Herrmann , Djalal Harouni , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2190 Lines: 48 Hi On Tue, Jun 9, 2015 at 11:00 PM, Sergei Zviagintsev wrote: > Enclose all arguments into parentheses in KDBUS_ITEM_FOREACH and > KDBUS_FOREACH macros to stay consistent across the whole macro. > > Signed-off-by: Sergei Zviagintsev > --- > tools/testing/selftests/kdbus/kdbus-util.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: David Herrmann Thanks David > diff --git a/tools/testing/selftests/kdbus/kdbus-util.h b/tools/testing/selftests/kdbus/kdbus-util.h > index df5721ee8f54..d1a0f1b4d0eb 100644 > --- a/tools/testing/selftests/kdbus/kdbus-util.h > +++ b/tools/testing/selftests/kdbus/kdbus-util.h > @@ -29,15 +29,15 @@ > #define KDBUS_ITEM_NEXT(item) \ > (typeof(item))((uint8_t *)(item) + KDBUS_ALIGN8((item)->size)) > #define KDBUS_ITEM_FOREACH(item, head, first) \ > - for (item = (head)->first; \ > + for ((item) = (head)->first; \ > ((uint8_t *)(item) < (uint8_t *)(head) + (head)->size) && \ > ((uint8_t *)(item) >= (uint8_t *)(head)); \ > - item = KDBUS_ITEM_NEXT(item)) > + (item) = KDBUS_ITEM_NEXT(item)) > #define KDBUS_FOREACH(iter, first, _size) \ > - for (iter = (first); \ > + for ((iter) = (first); \ > ((uint8_t *)(iter) < (uint8_t *)(first) + (_size)) && \ > ((uint8_t *)(iter) >= (uint8_t *)(first)); \ > - iter = (void *)(((uint8_t *)iter) + KDBUS_ALIGN8((iter)->size))) > + (iter) = (void *)((uint8_t *)(iter) + KDBUS_ALIGN8((iter)->size))) > > #define _KDBUS_ATTACH_BITS_SET_NR (__builtin_popcountll(_KDBUS_ATTACH_ALL)) > > -- > 1.8.3.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/