Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965449AbbFJOLc (ORCPT ); Wed, 10 Jun 2015 10:11:32 -0400 Received: from mail-lb0-f182.google.com ([209.85.217.182]:34189 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965046AbbFJOKK (ORCPT ); Wed, 10 Jun 2015 10:10:10 -0400 MIME-Version: 1.0 In-Reply-To: <85c48d5f0217240d2b100a093c8025555b93cedb.1433882692.git.sergei@s15v.net> References: <85c48d5f0217240d2b100a093c8025555b93cedb.1433882692.git.sergei@s15v.net> Date: Wed, 10 Jun 2015 16:10:08 +0200 Message-ID: Subject: Re: [PATCH v2 10/10] samples/kdbus: use parentheses uniformly in KDBUS_FOREACH macro From: David Herrmann To: Sergei Zviagintsev Cc: Greg Kroah-Hartman , Daniel Mack , David Herrmann , Djalal Harouni , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1585 Lines: 41 Hi On Tue, Jun 9, 2015 at 11:00 PM, Sergei Zviagintsev wrote: > Enclose all arguments into parentheses to stay consistent across the > whole macro. > > Signed-off-by: Sergei Zviagintsev > --- > samples/kdbus/kdbus-api.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: David Herrmann Thanks David > diff --git a/samples/kdbus/kdbus-api.h b/samples/kdbus/kdbus-api.h > index fab873b89d97..7f3abae18396 100644 > --- a/samples/kdbus/kdbus-api.h > +++ b/samples/kdbus/kdbus-api.h > @@ -10,10 +10,10 @@ > #define KDBUS_ITEM_NEXT(item) \ > (typeof(item))((uint8_t *)(item) + KDBUS_ALIGN8((item)->size)) > #define KDBUS_FOREACH(iter, first, _size) \ > - for (iter = (first); \ > + for ((iter) = (first); \ > ((uint8_t *)(iter) < (uint8_t *)(first) + (_size)) && \ > ((uint8_t *)(iter) >= (uint8_t *)(first)); \ > - iter = (void *)(((uint8_t *)iter) + KDBUS_ALIGN8((iter)->size))) > + (iter) = (void *)((uint8_t *)(iter) + KDBUS_ALIGN8((iter)->size))) > > static inline int kdbus_cmd_bus_make(int control_fd, struct kdbus_cmd *cmd) > { > -- > 1.8.3.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/