Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965237AbbFJOZv (ORCPT ); Wed, 10 Jun 2015 10:25:51 -0400 Received: from mail-ig0-f180.google.com ([209.85.213.180]:34548 "EHLO mail-ig0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965189AbbFJOZn (ORCPT ); Wed, 10 Jun 2015 10:25:43 -0400 MIME-Version: 1.0 In-Reply-To: <1433917970-46472-1-git-send-email-hare@suse.de> References: <1433917970-46472-1-git-send-email-hare@suse.de> Date: Wed, 10 Jun 2015 10:25:42 -0400 X-Google-Sender-Auth: Z5akMLTXAYi-Ov946Binm_Qmwgc Message-ID: Subject: Re: [PATCH] firmware: ACPI iBFT firmware support on EFI machines From: Josh Boyer To: Hannes Reinecke Cc: Mike Christie , "Linux-Kernel@Vger. Kernel. Org" , Konrad Rzeszutek Wilk , open-iscsi@googlegroups.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1694 Lines: 43 On Wed, Jun 10, 2015 at 2:32 AM, Hannes Reinecke wrote: > The iBFT firmware tables can also be specified via ACPI tables > when using EFI firmware. The 'iscsi_ibft_find' module is only > for legacy X86 BIOS, so it needs to be skipped for all other > architectures. If this is only valid for X86, you probably want to add a dependency on X86. There are other architectures that use ACPI, notable ia64 and arm64 in the not distant future. josh > Signed-off-by: Hannes Reinecke > --- > drivers/firmware/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig > index 6517132..79204b2 100644 > --- a/drivers/firmware/Kconfig > +++ b/drivers/firmware/Kconfig > @@ -124,7 +124,7 @@ config ISCSI_IBFT_FIND > config ISCSI_IBFT > tristate "iSCSI Boot Firmware Table Attributes module" > select ISCSI_BOOT_SYSFS > - depends on ISCSI_IBFT_FIND && SCSI && SCSI_LOWLEVEL > + depends on (ISCSI_IBFT_FIND || ACPI) && SCSI && SCSI_LOWLEVEL > default n > help > This option enables support for detection and exposing of iSCSI > -- > 1.8.5.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/