Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754301AbbFJOo2 (ORCPT ); Wed, 10 Jun 2015 10:44:28 -0400 Received: from mail-qk0-f172.google.com ([209.85.220.172]:33695 "EHLO mail-qk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754082AbbFJOoQ (ORCPT ); Wed, 10 Jun 2015 10:44:16 -0400 Message-ID: <1433947452.27504.9.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: [RFC,v3 02/10] dpaa_eth: add support for DPAA Ethernet From: Eric Dumazet To: Madalin-Cristian Bucur Cc: "linux-kernel@vger.kernel.org" , Jianhua Xie , "netdev@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" Date: Wed, 10 Jun 2015 07:44:12 -0700 In-Reply-To: References: <1430319405-31280-1-git-send-email-madalin.bucur@freescale.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 839 Lines: 20 On Wed, 2015-06-10 at 07:38 +0000, Madalin-Cristian Bucur wrote: > Hi Eric, > > Can you please tell us if this change would be for the better? > > I was about to say yes to this request but checked and no other Ethernet driver seems to use the queue trans_start. > I was able to find your patch "net: tx scalability works : trans_start" [ http://patchwork.ozlabs.org/patch/27104/ ] but did not find more about this topic. > Drivers no longer have to worry about updating trans_start themselves. Core networking stack handles this. Check txq_trans_update() done from netdev_start_xmit() -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/