Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966197AbbFJPys (ORCPT ); Wed, 10 Jun 2015 11:54:48 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:37193 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966180AbbFJPye (ORCPT ); Wed, 10 Jun 2015 11:54:34 -0400 MIME-Version: 1.0 In-Reply-To: <20150609063900.GD9804@lst.de> References: <20150602001134.4506.45867.stgit@dwillia2-desk3.amr.corp.intel.com> <20150602001514.4506.13974.stgit@dwillia2-desk3.amr.corp.intel.com> <20150609063900.GD9804@lst.de> Date: Wed, 10 Jun 2015 08:54:32 -0700 Message-ID: Subject: Re: [PATCH v5 12/21] libnvdimm: namespace indices: read and validate From: Dan Williams To: Christoph Hellwig Cc: "linux-nvdimm@lists.01.org" , Jens Axboe , Stephen Rothwell , "Rafael J. Wysocki" , Neil Brown , Greg KH , "linux-kernel@vger.kernel.org" , Ingo Molnar , Linux ACPI , jmoyer , linux-api@vger.kernel.org, Andrew Morton Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 831 Lines: 20 On Mon, Jun 8, 2015 at 11:39 PM, Christoph Hellwig wrote: >> +#include >> + >> +#ifndef __io_virt >> +#define __io_virt(x) ((void __force *) (x)) >> +#endif > > NAK. driver code mus never include asm-generic headers directly, > and __io_virt isn't something that's up to a driver to redefine either. > > I think we really need the memremap series in first before trying to > do the things done in this patch. I was abusing read[wlq] and write[wlq]. All this patch needs is a conversion to use __leXXto_cpu and __cpu_to_leXX helpers. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/